devpod-desktop: refactor; devpod{,-desktop}: 0.5.20 -> 0.6.15#341884
devpod-desktop: refactor; devpod{,-desktop}: 0.5.20 -> 0.6.15#341884doronbehar merged 2 commits intoNixOS:masterfrom
Conversation
530a944 to
f687e9d
Compare
|
Merge conflict :3 |
Resolved |
|
Devpod 0.5.x is stuck on Tauri v1. I went and did the update to 0.6.15 myself, mostly hoping to drop yet another Feel free to cherry-pick that into this PR. If not thats fine too, then i'll open this as a follow-up. |
LordGrimmauld
left a comment
There was a problem hiding this comment.
I can't test darwin, but the linux version seems to build and is already significantly more maintainable thanks to tauri hook. Good work!
|
If you do cherry-pick mind replacing the |
LordGrimmauld
left a comment
There was a problem hiding this comment.
Makes sense, thanks!
|
I'll also add |
0fd9412 to
3d06275
Compare
|
Okay, looks like the
I think I'll patch this logic out, since it's mostly incorrect anyways. |
a05db07 to
ca0ff65
Compare
|
Okay, I think I am finished with the refactoring. |
|
Uhhh... my All of the lines are this: I think I will have to patch this. |
|
Oh dear wtf! Good luck! |
- combine the frontent derivation into the main derivation - use cargo-tauri.hook - patch out sidecar file logic - patch out schema registering logic - add glib-networking for image loading - add darwin support - add myself as a maintainer
|
@nyabinary anything in particular you think I should be looking at here? |
Involved with the libsoup stuff removes a usage of libsoup and hasn't been reviewed by anyone else :3 |
|
That sounds great but there's a lot more than that going on here I don't know anything about. |
|
Description of changes
I did a refactor of devpod-desktop
Tracking issue for removal of
mkYarnPackageusages: #324246Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.