nufmt: improve code #341647
Closed
nufmt: improve code #341647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wegank
added
the
2.status: merge conflict
fdncred
pushed a commit
to nushell/nufmt
that referenced
this pull request
Oct 20, 2024
## Description of changes Updates the nushell crates, and adjusts the code according to the breaking changes. ## Relevant Issues NixOS/nixpkgs#341647
diniamo
force-pushed
the
update-nufmt
branch
2 times, most recently
from
38aed64 to
7de97fd
Compare
ofborg
bot
removed
the
2.status: merge conflict
ofborg
bot
added
10.rebuild-darwin: 0
|
Was already updated in #350498 |
diniamo
changed the title
|
In that case, we can still get this change in. |
|
Don't really see the benefit. Next staging cycle into master we'll be removing that section |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This is a draft, because the package doesn't compile, due to the rustc breaking change, and fixing that upstream requires the very long process of:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.