Closed
Conversation
SFrijters
force-pushed
the
itstool-cross
branch
from
e8666ba to
194fd27
Compare
ofborg
bot
added
6.topic: cross-compilation
Member
Author
|
Retargeted to staging because of the large number of rebuilds. |
SFrijters
force-pushed
the
itstool-cross
branch
from
194fd27 to
d0e231a
Compare
Member
Author
|
Running the native code still works, and running aarch64 via binfmt works as well. The program spits out a bunch of warnings - we could consider pulling in itstool/itstool#51 to fix that. |
ofborg
bot
requested review from
adevress,
amiloradovsky,
bjornfor,
gebner and
prusnak
bjornfor
approved these changes
Sep 14, 2024
Contributor
bjornfor
left a comment
bjornfor
left a comment
There was a problem hiding this comment.
I'd like to see
Fixes configure: error: Python module libxml2 is needed to run this package, for e.g. nix build .#pkgsCross.aarch64-multiplatform.itstool.
in the commit message as well, because that's what goes into git. But it's not a blocker.
Fixes configure step `error: Python module libxml2 is needed to run this package`, for e.g. nix build .#pkgsCross.aarch64-multiplatform.itstool.
SFrijters
force-pushed
the
itstool-cross
branch
from
d0e231a to
9b83c79
Compare
Member
Author
|
Amended the commit message, thanks for the review. |
wegank
added
12.approvals: 1
Member
|
Output depends on the build python In addition to the build script checking the python wrong there's also a bug in wrapPython related to the python splicing which #228139 will fix one day Simplest fix would be to replace the build python references because the other paths are correct. |
Member
Author
|
Sorry, I don't understand - how can I tell that that is the build python (and not the host python) when not cross-compilling? If I build it for As far as I can tell the final package is a Python script so we need an interpreter, no? |
Artturin
reviewed
Sep 15, 2024
pkgs/by-name/it/itstool/package.nix
Outdated
Comment on lines
5
to
6
| buildPackages, | ||
| python3, |
Member
There was a problem hiding this comment.
Suggested change
| buildPackages, | |
| python3, | |
| python3Packages, |
python3Packages is spliced so use it instead
Member
You can't since they'll be identical when build == host == target
I applied the changes in the first commit to master and what's in my previous comment is what I see, do you have binfmt enabled? because that can hide cross issues so it shouldn't be used when working on nixpkgs. |
Member
Author
|
I thought I had disabled binfmt in my config for just this reason, but it may have required a reboot to apply? |
Artturin
reviewed
Sep 15, 2024
pkgs/by-name/it/itstool/package.nix
Outdated
Comment on lines
22
to
23
Member
There was a problem hiding this comment.
Suggested change
| buildPackages.python3 | |
| buildPackages.python3Packages.libxml2 | |
| python3Packages.python | |
| python3Packages.libxml2 |
SFrijters
force-pushed
the
itstool-cross
branch
from
025cedb to
6ac6165
Compare
wegank
added
the
2.status: merge conflict
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes
configure: error: Python module libxml2 is needed to run this package, for e.g.nix build .#pkgsCross.aarch64-multiplatform.itstool.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.