Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

waybar: 0.10.4 -> 0.11.0 #341520

Merged
merged 1 commit into from
Sep 16, 2024
Merged

waybar: 0.10.4 -> 0.11.0 #341520

merged 1 commit into from
Sep 16, 2024

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Sep 13, 2024 •
edited by JohnRTitor
Loading

Description of changes

Changelog: https://github.com/alexays/waybar/releases/tag/0.11.0

Closes #342195

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 341520 run on x86_64-linux 1

1 package built:
  • waybar

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 341520 run on aarch64-linux 1

1 package built:
  • waybar

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 13, 2024
@khaneliman
Copy link
Contributor

Result of nixpkgs-review pr 341520 run on x86_64-linux 1

1 package built:
  • waybar

@khaneliman
Copy link
Contributor

khaneliman commented Sep 13, 2024 •
edited
Loading

Update works, but looks like there's a waybar regression with system tray.. bleh Alexays/Waybar#3597

JohnRTitor
JohnRTitor requested changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's block this until we have a patch for Alexays/Waybar#3597.

We don't want to break user experience.

@iynaix
Copy link
Contributor

iynaix commented Sep 16, 2024

Fix appears to have been merged: Alexays/Waybar@0d02f68

@khaneliman
Copy link
Contributor

Fix appears to have been merged: Alexays/Waybar@0d02f68

Sorry, meant to create a PR with the patch, but haven’t gotten around to it.

@khaneliman khaneliman mentioned this pull request Sep 16, 2024
Closed
13 tasks
@GaetanLepage
Copy link
Contributor Author

I fetched the patch in question. It should be working now. (to be tested)

@JohnRTitor
Copy link
Contributor

Result of nixpkgs-review pr 341520 run on x86_64-linux 1

1 package built:
  • waybar

@JohnRTitor JohnRTitor self-assigned this Sep 16, 2024
@JohnRTitor
Copy link
Contributor

Tested and works fine, will merge once eval passes.

@JohnRTitor JohnRTitor merged commit 8c9630d into NixOS:master Sep 16, 2024
25 of 29 checks passed
@GaetanLepage GaetanLepage deleted the waybar branch September 16, 2024 11:24
@dezren39 dezren39 mentioned this pull request Sep 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnRTitor JohnRTitor JohnRTitor approved these changes

@minijackson minijackson Awaiting requested review from minijackson

@FlorianFranzen FlorianFranzen Awaiting requested review from FlorianFranzen

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

@lovesegfault lovesegfault Awaiting requested review from lovesegfault

@rodrgz rodrgz Awaiting requested review from rodrgz

@khaneliman khaneliman Awaiting requested review from khaneliman

Assignees

@JohnRTitor JohnRTitor

Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GaetanLepage @khaneliman @iynaix @JohnRTitor