nixos/samba: ensure global section is always first

[bachp]

Description of changes

The order of the [global] section matters as settings defined there are only applied to shares that are defines after it.

This change ensures the global section always comes first in the resulting smb.conf.

Fixes regression introduced in #302681 (comment)

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[misuzu]

Tested on my NAS, thanks!

[anthonyroussel]

Thank you very much for your help!
Sorry I was not very available yesterday to fix that.

I tested the fix, it works perfectly!

services.samba = {
  enable = true;
  openFirewall = true;
  settings = {
    global = {
      "guest ok" = true;
    };
    "public" = {
      "path" = "/public";
      "browseable" = "yes";
      "comment" = "Public samba share.";
    };
    "Shared" = {
      "path" = "/private";
      "browseable" = "yes";
      "comment" = "Shared samba share.";
    };
  };
};

The Shared and public shares in this configuration are now allowing guest access.