nixos/samba: revert default values

[anthonyroussel]

Description of changes

See #302681 (review)

Reorganizing the module options with RFC0042 and breaking the default values at the time, makes the migration too complicated.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[anthonyroussel]

@ofborg test samba

[yshui]

looks reasonable, but I can't say I am too familiar with option type definitions.

did you check the generated smb.conf without any user settings? if that works that's good enough for me.

[anthonyroussel]

Test 1 with default values

services.samba = {
  enable = true;
  settings = {
    "public" = {
      "path" = "/public";
      "read only" = true;
      "browseable" = "yes";
      "guest ok" = "yes";
      "comment" = "Public samba share.";
    };
  };
};

results in /etc/samba/smb.conf

[global]
invalid users=root
passwd program=/run/wrappers/bin/passwd %u
security=user

[public]
browseable=yes
comment=Public samba share.
guest ok=yes
path=/public
read only=true

Test 2 with global setting overrides

services.samba = {
  enable = true;
  settings = {
    "global" = {
      "invalid users" = [ "root" "nixos-user" ];
      "passwd program" = "/dev/null";
      "security" = "ads";
    };
    "public" = {
      "path" = "/public";
      "read only" = true;
      "browseable" = "yes";
      "guest ok" = "yes";
      "comment" = "Public samba share.";
    };
  };
};

results in /etc/samba/smb.conf

[global]
invalid users=root nixos-user
passwd program=/dev/null
security=ads

[public]
browseable=yes
comment=Public samba share.
guest ok=yes
path=/public
read only=true

Default values are now back ✔️