qtscrcpy: init at 2.2.1

[Daru-san]

Description of changes

Adds qt-scrcpy, a qt frontend for scrcpy.
Homepage : https://github.com/barry-ran/QtScrcpy

Build unsuccessful at the moment, help would be great 😄

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[Daru-san]

Currently stuck getting this error:

┃        > /build/source/QtScrcpy/util/mousetap/xmousetap.cpp: In function 'void find_grab_window_recursive(xcb_connection_t*, xcb_window_t, QRect, int16_t, int16_t, xcb_window_t*, uint32_t*)':
┃        > /build/source/QtScrcpy/util/mousetap/xmousetap.cpp:34:57: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
┃        >    34 |             if (!*grab_window || gg->width * gg->height <= *grab_window_size) {
┃        >       |                                  ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
┃        > At global scope:
┃        > cc1plus: note: unrecognized command-line option '-Wno-nested-anon-types' may have been intended to silence earlier diagnostics
┃        > cc1plus: all warnings being treated as errors
┃        > make[2]: *** [QtScrcpy/CMakeFiles/QtScrcpy.dir/build.make:248: QtScrcpy/CMakeFiles/QtScrcpy.dir/util/mousetap/xmousetap.cpp.o] Error 1
┃        > make[2]: *** Waiting for unfinished jobs....
┃        > make[1]: *** [CMakeFiles/Makefile2:121: QtScrcpy/CMakeFiles/QtScrcpy.dir/all] Error 2
┃        > make: *** [Makefile:91: all] Error 2
┃        For full logs, run 'nix log /nix/store/q5h1dib9s3pqx1473fl02a9yvfp0av9w-qt-scrcpy-2.2.1.drv'.

[Daru-san]

I found a way to get around it using

{  
  env.NIX_CFLAGS_COMPILE = toString [
    "-Wno-error=sign-compare"
  ];
}

[Daru-san]

But now I am stumped by this:

make: *** No rule to make target 'install'.  Stop.

[Daru-san]

Build successful 😄

[Aleksanaa]

The attribute name and pname should be qtscrcpy

[Daru-san]

There is an issue preventing the build from happening, it affects my system and github CI. Apparently the submodule QtScrcpyCore, from the repo https://github.com/barry-ran/QtScrcpyCore cannot be cloned, giving this error

┃        > Cloning into '/nix/store/dkb5z7p60vy3l52lv42i5jiib374skyb-source/QtScrcpy/QtScrcpyCore'...
┃        > error: cannot run ssh: No such file or directory
┃        > fatal: unable to fork
┃        > fatal: clone of 'git@github.com:barry-ran/QtScrcpyCore.git' into submodule path '/nix/store/dkb5z7p60vy3l52lv42i5jiib374skyb-source/QtScrcpy/QtScrcpyCore' fail…
┃        > Failed to clone 'QtScrcpy/QtScrcpyCore'. Retry scheduled
┃        > Cloning into '/nix/store/dkb5z7p60vy3l52lv42i5jiib374skyb-source/QtScrcpy/QtScrcpyCore'...
┃        > error: cannot run ssh: No such file or directory
┃        > fatal: unable to fork
┃        > fatal: clone of 'git@github.com:barry-ran/QtScrcpyCore.git' into submodule path '/nix/store/dkb5z7p60vy3l52lv42i5jiib374skyb-source/QtScrcpy/QtScrcpyCore' fail…
┃        > Failed to clone 'QtScrcpy/QtScrcpyCore' a second time, aborting
┃        For full logs, run 'nix log /nix/store/nfa9swir54ydyv38f3c2yrvfgb1zki8w-source.drv'.

[Aleksanaa]

There is an issue preventing the build from happening, it affects my system and github CI. Apparently the submodule QtScrcpyCore, from the repo barry-ran/QtScrcpyCore cannot be cloned, giving this error

See #195117. The best option here would be manually copying that repo to store, since we don't have a lot of submodules. I'll try to fix fetchgit.

edit: #195117 (comment) would be fine.

[Daru-san]

There is an issue preventing the build from happening, it affects my system and github CI. Apparently the submodule QtScrcpyCore, from the repo barry-ran/QtScrcpyCore cannot be cloned, giving this error

See #195117. The best option here would be manually copying that repo to store, since we don't have a lot of submodules. I'll try to fix fetchgit.

edit: #195117 (comment) would be fine.

Cool, the solution in the provided issue works perfectly. My question is just if this would be a temporary fix to keep until the issue has been resolved properly

[Aleksanaa]

There's vendor blob hidden in https://github.com/barry-ran/QtScrcpyCore/tree/5f0359053fb67f2226fcc87919aee0de17d2079b/src/third_party/ffmpeg/lib, which makes it unable to build on other architectures (and we should avoid unneeded blobs), see ofBorg https://logs.ofborg.org/?key=nixos/nixpkgs.340257&attempt_id=fe9242e4-8d56-41ff-8b7f-b817305c2b7f. There should be some options lying somewhere in cmake files. Do you think you can handle it? I can help you if you can't.

[Aleksanaa]

I'm working on it. (Anyway I feel that this behavior is actually a bit malicious. Maybe it is really doing some bad things secretly)

[Daru-san]

Oh I definitely did not realize that, I don't really get what it may be doing, I need to do more research into that, package compilation as a whole. But I would love to understand what it's doing, if you could explain.

[Aleksanaa]

I don't really get what it may be doing, I need to do more research into that

tldr. it's not only vendoring ffmpeg blobs, but also scrcpy-server and adb in git submodules. This is very suspicious, because adb is a privileged operation for android, and scrcpy-server will be installed on the android system. Some users may not notice these pre-built binaries hidden in this open source project.

[myclevorname]

Should we close the PR?

[Aleksanaa]

Not necessarily, we can also try to replace the blob

[Daru-san]

I know this question may not be helpful, but how would you go about replacing the blob?

I assume you would somehow patch the source or maybe fork the repo and manually replace them.

[Aleksanaa]

Resolved

[Daru-san]

@Aleksanaa Thanks a whole lot for that, build is successful 😄

[Daru-san]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 340257

---

x86_64-linux

✅ 1 package built:

• qtscrcpy

[Aleksanaa]

Still have to fix it a bit on macOS

[emilazy]

Does this package only support FFmpeg 4? We are trying to get rid of it and this is the only user other than ROCm and the binary packages for Spotify and REAPER.

[Aleksanaa]

The upstream vendored this version, so I replaced it with the same package. I can try to see if it still compiles after replacing it with a higher version