pre-commit: add rustup and gcc to support nixpkgs-fmt pre-commit-hook support#340113
Open
MSchmoecker wants to merge 1 commit intoNixOS:masterfrom
Open
pre-commit: add rustup and gcc to support nixpkgs-fmt pre-commit-hook support#340113MSchmoecker wants to merge 1 commit intoNixOS:masterfrom
MSchmoecker wants to merge 1 commit intoNixOS:masterfrom
Conversation
FliegendeWurst
approved these changes
Oct 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Rustup and gcc are needed in the PATH to use the nixpkgs-fmt pre-commit hook. Otherwise, pre-commit tries to install the dependencies in the pre-commit toolchain and fails:
Without gcc (only rustup):
While nixpkgs-fmt is deprecated, the replacement nixfmt does not contain pre-commit hooks in the 0.6.0 release and was just merged NixOS/nixfmt#238 on the master branch. Thus, this PR adds toolchain support for nixpkgs-fmt until nixfmt is stable.
I am not completely sure if adding the dependencies to nixpkgs is the best place, however it makes the installation of pre-commit for nix related projects much easier.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.