Merged
Conversation
Member
|
I guess this would break |
Contributor
Author
It would also break:
I do indeed claim that we don't care. |
Member
|
I think the difference is that it was intentional that it would apply to the |
ofborg
bot
added
10.rebuild-darwin: 0
philiptaron
force-pushed
the
avahi-madness
branch
from
f575977 to
f6cd0d3
Compare
Contributor
Author
|
I added in a message. |
emilazy
approved these changes
Sep 3, 2024
Member
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
Seems reasonable. Can you add a comment mentioning 24.11 so we know when we can safely drop it?
This was added in 6832a42, which replaced an attrset with `qt4Support = config.avahi.qt4Support or false;`. As qt4 support is now out of the tree, so should this be as well.
philiptaron
force-pushed
the
avahi-madness
branch
from
f6cd0d3 to
26a7a87
Compare
Contributor
Author
Done. |
emilazy
approved these changes
Sep 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This was added in 6832a42, which replaced a call that
qt4Support = config.avahi.qt4Support or false;.As qt4 support is now out of the tree, so should this be as well.
See also:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)