Skip to content

Comments

haskellPackages.diohsc: unbreak#339302

Merged
maralorn merged 3 commits intoNixOS:haskell-updatesfrom
marcin-serwin:unbreak-diohsc
Sep 7, 2024
Merged

haskellPackages.diohsc: unbreak#339302
maralorn merged 3 commits intoNixOS:haskell-updatesfrom
marcin-serwin:unbreak-diohsc

Conversation

@marcin-serwin
Copy link
Contributor

Description of changes

diohsc is marked as broken because it fails to build with tls 1.8. It builds successfully with tls 2.0.6.

Things done

Override scope of diohsc and mark it as non broken.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Sep 3, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 3, 2024
@maralorn
Copy link
Member

maralorn commented Sep 7, 2024

Thank you!

  1. Please retarget this PR at the haskell-updates branch. (Be sure to mark as draft during the branch switch because that sometimes creates mass pings.)
  2. Optional: run maintainers/scripts/haskell/regenerate-hackage-packages.nix in your commit, so that all changes go together.
  3. Optional: Elaborate the comment a bit. E.g. when this override was added or when the override can be removed. (But I guess with a bit of thinking the current comment is okay.)

@marcin-serwin marcin-serwin marked this pull request as draft September 7, 2024 17:52
@marcin-serwin marcin-serwin changed the base branch from master to haskell-updates September 7, 2024 17:52
@marcin-serwin marcin-serwin marked this pull request as ready for review September 7, 2024 18:03
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 7, 2024
@maralorn
Copy link
Member

maralorn commented Sep 7, 2024

Ex-cell-ent

@maralorn maralorn merged commit adf1e11 into NixOS:haskell-updates Sep 7, 2024
@marcin-serwin marcin-serwin deleted the unbreak-diohsc branch March 9, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants