buildGoModule: be nicer when overrideAttrs clears passthru

[SuperSandro2000]

Before an overlay in the form of:

package.overrideAttrs (old: {
  passthru = {};
})

would fail evaluation like:

   error: attribute 'overrideModAttrs' missing
   at /nix/store/afwc3m1sm49qq57xjv2hmd7iy4x0j33h-source/pkgs/build-support/go/module.nix:179:20:
      178|     outputHashAlgo = if finalAttrs.vendorHash == "" then "sha256" else null;
      179|   }).overrideAttrs finalAttrs.passthru.overrideModAttrs;
         |                    ^
      180|

Now instead we take the fallback default.

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[doronbehar]

Before an overlay in the form of:

package.overrideAttrs (old: {
  passthru = {};
})

Just out of curiosity why would you apply that overlay?

[SuperSandro2000]

The complete code puts a static asset into passthru. Since the original package has not passthru, being required to merge it felt unintuitive.