Skip to content

llvm-5: add extra 'python' output for opt-viewer tool#33871

Merged
LnL7 merged 1 commit intoNixOS:stagingfrom
dtzWill:fix/llvm-5-python-closure
Feb 6, 2018
Merged

llvm-5: add extra 'python' output for opt-viewer tool#33871
LnL7 merged 1 commit intoNixOS:stagingfrom
dtzWill:fix/llvm-5-python-closure

Conversation

@dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 14, 2018

#33374 (review)

We don't really support the opt-viewer tool anyway,
but keep it around in case someone wants to play with it.

Don't pull python into the closure just for that reason, though.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill force-pushed the fix/llvm-5-python-closure branch from fa51207 to 5953295 Compare January 14, 2018 22:53
@dtzWill dtzWill changed the base branch from master to staging January 14, 2018 22:54
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Jan 14, 2018
@vcunat
Copy link
Member

vcunat commented Jan 14, 2018

Sounds OK to me.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. and removed 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels Jan 14, 2018
@dtzWill
Copy link
Member Author

dtzWill commented Jan 17, 2018

We could alternatively delete it, but saving it to an extra output seems a bit kinder :).

Eventually we can try wrapping it or something to get it working, but mostly want to fix Darwin closure with LLVM 5.

Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in principle, testing if this helps with the stdenv references.

@LnL7 LnL7 mentioned this pull request Feb 1, 2018
8 tasks
@dtzWill
Copy link
Member Author

dtzWill commented Feb 2, 2018

@LnL7 we have a "success" regarding this resolving the references problem right?

I suppose there's no rush motivating merging this separately from #33374, but just checking :).

EDIT: Conflict resolution underway... done!

@dtzWill dtzWill force-pushed the fix/llvm-5-python-closure branch from 5953295 to 64e4c98 Compare February 2, 2018 12:30
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. and removed 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. labels Feb 2, 2018
@LnL7 LnL7 merged commit 335ae38 into NixOS:staging Feb 6, 2018
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Mar 8, 2018
Unlike that PR, however, this doesn't need to go to staging
since no one depends on a package that doesn't exist yet :).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants