llvm-5: add extra 'python' output for opt-viewer tool#33871
Merged
LnL7 merged 1 commit intoNixOS:stagingfrom Feb 6, 2018
Merged
llvm-5: add extra 'python' output for opt-viewer tool#33871LnL7 merged 1 commit intoNixOS:stagingfrom
LnL7 merged 1 commit intoNixOS:stagingfrom
Conversation
fa51207 to
5953295
Compare
Member
|
Sounds OK to me. |
Member
Author
|
We could alternatively delete it, but saving it to an extra output seems a bit kinder :). Eventually we can try wrapping it or something to get it working, but mostly want to fix Darwin closure with LLVM 5. |
LnL7
approved these changes
Jan 31, 2018
Member
LnL7
left a comment
There was a problem hiding this comment.
Looks good in principle, testing if this helps with the stdenv references.
Member
Author
5953295 to
64e4c98
Compare
dtzWill
added a commit
to dtzWill/nixpkgs
that referenced
this pull request
Mar 8, 2018
Unlike that PR, however, this doesn't need to go to staging since no one depends on a package that doesn't exist yet :).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#33374 (review)
We don't really support the opt-viewer tool anyway,
but keep it around in case someone wants to play with it.
Don't pull python into the closure just for that reason, though.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)