weblate: address additional review on package and dependencies#338217
Merged
fricklerhandwerk merged 12 commits intoNixOS:masterfrom Sep 4, 2024
Merged
weblate: address additional review on package and dependencies#338217fricklerhandwerk merged 12 commits intoNixOS:masterfrom
fricklerhandwerk merged 12 commits intoNixOS:masterfrom
Conversation
13 tasks
dotlambda
reviewed
Aug 29, 2024
Member
dotlambda
left a comment
There was a problem hiding this comment.
You didn't remove borgbackup from dependencies.
Member
Author
|
fricklerhandwerk
approved these changes
Aug 31, 2024
Contributor
fricklerhandwerk
left a comment
There was a problem hiding this comment.
@erictapen Thanks for following up on the review notes
GetPsyched
suggested changes
Aug 31, 2024
pkgs/development/python-modules/django-crispy-bootstrap5/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/django-crispy-bootstrap5/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/django-crispy-bootstrap4/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/django-crispy-bootstrap3/default.nix
Outdated
Show resolved
Hide resolved
dotlambda
reviewed
Aug 31, 2024
Member
Author
|
I went through and double-checked all the licenses introduced by #325541 and #334849:
I actually had to fix the license for Weblate vendors in a few dependencies with licenses such as As laid out in #338217 (comment), I'd leave CC0 licenses in files like
|
…system, sort dependencies
some files are actually licensed by MIT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Addresses @dotlambda s reviews in #325541 (comment) and #334849 (review).
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.