[24.05] feishin: backports#337949
Merged
emilazy merged 3 commits intoNixOS:release-24.05from Aug 29, 2024
Merged
Conversation
Addresses NixOS#319252: v27 has been EOL since 2024/04/16. (cherry picked from commit 5e4fd0a)
(cherry picked from commit 3a83109)
As originally mentioned in NixOS#331868, feishin now [1] depends on Electron v31, which was not packaged at the time (NixOS#325428). It has since been fixed (by NixOS#333907). [1]: https://github.com/jeffvli/feishin/blob/f2beeef/package.json#L234 (cherry picked from commit 3d15951)
13 tasks
ofborg
bot
added
10.rebuild-darwin: 1-10
jlbribeiro
approved these changes
Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
See #337776.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.