Skip to content

[Backport release-24.05] ride: add patch to support later electron versions #337788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emilazy merged 1 commit into from
Aug 28, 2024
Merged

[Backport release-24.05] ride: add patch to support later electron versions #337788

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions pkgs/by-name/ri/ride/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,15 @@
stdenv,
buildNpmPackage,
fetchFromGitHub,
fetchpatch,
substituteAll,
jq,
moreutils,
zip,
makeWrapper,
copyDesktopItems,
makeDesktopItem,
electron_27,
electron,
}:

let
Expand All @@ -30,9 +31,6 @@ let
};

platformInfo = platformInfos.${stdenv.system};

# Electron 27 is the latest version that works as of RIDE version 4.5.4097
electron = electron_27;
in
buildNpmPackage rec {
pname = "ride";
Expand All @@ -45,9 +43,15 @@ buildNpmPackage rec {
hash = "sha256-xR+HVC1JVrPkgPhIJZxdTVG52+QbanmD1c/uO5l84oc=";
};

npmDepsHash = "sha256-EG3pZkjDGBI2dDaQZ6351+oU4xfHd6HNB8eD7ErpYIg=";
npmDepsHash = "sha256-h+48/9h7/cD8woyA0UCLtzKuE9jCrfpDk6IeoDWnYik=";

patches = [
# Adds support for electron versions >=28
(fetchpatch {
name = "bump-electron-version.patch";
url = "https://github.com/Dyalog/ride/commit/de42ebbd5036cfe0c7e6604296e87cc57ac9d365.patch";
hash = "sha256-5iKSNcxOOo2fKNvy3Rv+AlH3psYhLWLWUY0l8M6mAD4=";
})
# Fix info in the "about" page, set electron version, set local-cache as zipdir
(substituteAll {
src = ./mk.patch;
Expand Down