workflows/check-nix-format: Improve error message#337577
workflows/check-nix-format: Improve error message#337577infinisil merged 1 commit intoNixOS:masterfrom
Conversation
Looks like the error message could be a bit clearer still: NixOS#337109 (comment)
github-actions
bot
added
the
6.topic: policy discussion
ofborg
bot
added
10.rebuild-darwin: 0
|
Who is @NixOS/nix-formatting? It should highlight to a github account. |
|
@Redhawk18 Not sure what you mean. That's a GitHub team, comprised of the people on the Nix Formatting Team, and it's highlighted for me |
|
@infinisil only for org members iirc :/ |
|
There's one other thing I wanted to mention but kept forgetting about: |
MattSturgeon
left a comment
MattSturgeon
left a comment
There was a problem hiding this comment.
I agree this is clearer, +1 from me 🙂
| if (( "${#unformattedFiles[@]}" > 0 )); then | ||
| echo "Some new/changed Nix files are not properly formatted" | ||
| echo "Please go to the Nixpkgs root directory, run \`nix-shell\`, then:" | ||
| echo "Please format them using the Nixpkgs-specific \`nixfmt\` by going to the Nixpkgs root directory, running \`nix-shell\`, then:" |
There was a problem hiding this comment.
If this were single-quoted, I think the backticks wouldn't need escaping anymore?
| echo "Please format them using the Nixpkgs-specific \`nixfmt\` by going to the Nixpkgs root directory, running \`nix-shell\`, then:" | |
| echo 'Please format them using the Nixpkgs-specific `nixfmt` by going to the Nixpkgs root directory, running `nix-shell`, then:' |
Not important though, if you'd rather consistently use double-quotes.
MattSturgeon
added
12.approvals: 2
|
Let's aim for more optimistic merging :D |
8 participants
Description of changes
Looks like the error message could be a bit clearer still: #337109 (comment) 😄
Ping @NixOS/nix-formatting
Add a 👍 reaction to pull requests you find important.