libphidget22: init at 0-unstable-2024-04-11#337398
Merged
drupol merged 1 commit intoNixOS:masterfrom Oct 12, 2024
Merged
Conversation
ofborg
bot
added
8.has: package (new)
mksafavi
force-pushed
the
libphidget22
branch
from
ffce327 to
41022b0
Compare
Member
Author
|
Hi. thanks for reviewing this. I added the suggestions you made. I also enabled strictDebs. I think the original package requester wasn't sure about the license that's why they listed many of them. checking here phidget license they only mention BSD3. |
mksafavi
force-pushed
the
libphidget22
branch
from
41022b0 to
7732e95
Compare
Member
Author
|
Hi. |
drupol
approved these changes
Oct 12, 2024
Member
|
The two hashes don't match (anymore). |
Contributor
|
How are we supposed to deal with packages that doesn't have a unique URL per version ? |
Member
|
Yeah, that's bad. I don't know. Someone could tell them that it's annoying. |
Contributor
|
@mksafavi Are you willing to help with this? |
Member
Author
|
Hi. I have created a new PR that fixes this issue I think. on that update PR the url is changed to a fixed version one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
closes #335946
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.