Skip to content

python312Packages.rns: unvendor esptool#337346

Merged
dotlambda merged 1 commit intoNixOS:masterfrom
dotlambda:python3Packages.rns
Sep 2, 2024
Merged

python312Packages.rns: unvendor esptool#337346
dotlambda merged 1 commit intoNixOS:masterfrom
dotlambda:python3Packages.rns

Conversation

@dotlambda
Copy link
Member

Description of changes

fixes #336766
closes #337285

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 25, 2024
@dotlambda dotlambda force-pushed the python3Packages.rns branch 2 times, most recently from bdaa5a0 to a254231 Compare August 25, 2024 22:24
@ofborg ofborg bot requested a review from fabaff August 25, 2024 23:20
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 25, 2024
@sgiath
Copy link
Contributor

sgiath commented Aug 26, 2024

I have tried it locally and this is the log I have got:

[10:05:41] Checking firmware file availability...
[10:05:41] Retrieving latest version info from https://unsigned.io/firmware/latest/?v=2.1.3&variant=rnode_firmware_lora32v21_tcxo.zip
[10:05:42] The selected firmware for this board is version 1.72
[10:05:42] Using existing firmware file: rnode_firmware_lora32v21_tcxo.zip for version 1.72
[10:05:42] Verifying firmware integrity...
[10:05:43] Decompressing firmware...
[10:05:43] Firmware decompressed
[10:05:43] Flashing RNode firmware to device on /dev/ttyACM0
[10:05:43] Error while flashing
[10:05:43] [Errno 2] No such file or directory: '/nix/store/hcyz3k527z9429b0i64f1nazbl72nrji-esptool-4.7.0/bin/esptool.py--chip'

You just probably need to add space after the path

@dotlambda dotlambda force-pushed the python3Packages.rns branch from a254231 to e932a24 Compare August 26, 2024 16:11
@sgiath
Copy link
Contributor

sgiath commented Aug 26, 2024

I am getting an error while connecting to the radio and trying to flash it. I don't know if it is because there is an issue with the esptools or on my end. Flashing those boards can be tricky even under normal circumstances 🤷🏻 but this is furthest I have gotten so far with this Nix package

image

@dotlambda dotlambda force-pushed the python3Packages.rns branch from e932a24 to 3b7343c Compare August 27, 2024 21:27
@dotlambda dotlambda merged commit 4db9246 into NixOS:master Sep 2, 2024
@dotlambda dotlambda deleted the python3Packages.rns branch September 2, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RNS python package does not recognize dependencies

2 participants