[24.05] morgen: electron_29 -> electron_30#337320
Merged
emilazy merged 7 commits intoNixOS:release-24.05from Aug 27, 2024
Merged
[24.05] morgen: electron_29 -> electron_30#337320emilazy merged 7 commits intoNixOS:release-24.05from
emilazy merged 7 commits intoNixOS:release-24.05from
Conversation
Member
Author
|
Result of 1 package built:
|
Member
Author
|
@justanotherariel Do you know if 3.4.2 will work with Electron 30 or if we need to backport the 3.5.5 update as well? |
22 tasks
Contributor
|
Hm, I can't test it because it complains that I'm downgrading - I would need to remove all related files first and I don't want to break things on my machine. I'd say, it's likely that it will still work, but since there are no breaking changes (just added features and performance improvements) in morgen version 3.5.5, probably just upgrade? Just to be on the safe side. |
0cb37a9 to
fdd1865
Compare
Member
Author
|
@justanotherariel I’ve backported the bumps – please take a look :) |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Manual backport of #336026.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.