Skip to content

Comments

bitwarden-desktop: 2024.6.4 -> 2024.8.0#337164

Merged
dotlambda merged 1 commit intoNixOS:masterfrom
amarshall:bitwarden-update
Aug 25, 2024
Merged

bitwarden-desktop: 2024.6.4 -> 2024.8.0#337164
dotlambda merged 1 commit intoNixOS:masterfrom
amarshall:bitwarden-update

Conversation

@amarshall
Copy link
Member

@amarshall amarshall commented Aug 25, 2024

Diff: bitwarden/clients@desktop-v2024.6.4...desktop-v2024.8.0

Changelog: https://github.com/bitwarden/clients/releases/tag/desktop-v2024.7.1
https://github.com/bitwarden/clients/releases/tag/desktop-v2024.8.0

  • The postPatch to fixup broken package{,-lock}.json in upstream seems to be no longer needed, so (happily) remove
  • Python 3.12 removed distutils, so get it from setuptools
  • Workaround broken node-argon2 dependency due to being updated (see inline comment)
  • desktop_native/napi was split out of desktop_native, so adjust accordingly

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

closes #330137


Add a 👍 reaction to pull requests you find important.

Diff: bitwarden/clients@desktop-v2024.6.4...desktop-v2024.8.0

Changelog: https://github.com/bitwarden/clients/releases/tag/desktop-v2024.7.1
           https://github.com/bitwarden/clients/releases/tag/desktop-v2024.8.0

- The postPatch to fixup broken package{,-lock}.json in upstream seems
  to be no longer needed, so (happily) remove
- Python 3.12 removed distutils, so get it from setuptools
- Workaround broken node-argon2 dependency due to being updated (see
  inline comment)
- desktop_native/napi was split out of desktop_native, so adjust
  accordingly

Co-authored-by: Robert Schütz <mail@dotlambda.de>
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 25, 2024
@github-actions
Copy link
Contributor

Successfully created backport PR for release-24.05:

@amarshall amarshall deleted the bitwarden-update branch August 25, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants