Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perlPackages.Appcpanminus: fix https hotpatch #337034

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Aug 24, 2024

Description of changes

For App::cpanminus:

  • Add replace missing cpan.metacpan.org URL

  • Use replace-fail instead of replace

Ref: Perl/docker-perl#167

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

- Add replace missing `cpan.metacpan.org` URL

- Use replace-fail instead of replace
@stigtsp
Copy link
Member Author

stigtsp commented Aug 24, 2024

@ofborg eval

@stigtsp stigtsp added 1.severity: security Issues which raise a security issue, or PRs that fix one backport release-24.05 Backport PR automatically labels Aug 24, 2024
@zakame
Copy link
Member

zakame commented Aug 25, 2024

Result of nixpkgs-review pr 337034 run on x86_64-linux 1

6 packages built:
  • imapsync
  • lanraragi
  • perl536Packages.Appcpanminus
  • perl536Packages.Appcpanminus.devdoc
  • perl538Packages.Appcpanminus
  • perl538Packages.Appcpanminus.devdoc

@NickCao NickCao merged commit fe65d16 into NixOS:master Aug 25, 2024
26 checks passed
Copy link
Contributor

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 backport release-24.05 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants