[master] haskellPackages.{ffmpeg-light,opencv{,-extra}}: remove overrides#336675
Merged
K900 merged 2 commits intoNixOS:masterfrom Aug 23, 2024
Merged
[master] haskellPackages.{ffmpeg-light,opencv{,-extra}}: remove overrides#336675K900 merged 2 commits intoNixOS:masterfrom
K900 merged 2 commits intoNixOS:masterfrom
Conversation
This package has been marked as broken for a year. If anyone wants to fix it, there is a pull request updating it to the current FFmpeg API: <acowley/ffmpeg-light#72>. (cherry picked from commit 7ce990f)
These packages have been broken since before the 24.05 release. There is a pull request open to update them to a newer OpenCV and get them working again: <LumiGuide/haskell-opencv#157>. (cherry picked from commit 79872e0)
github-actions
bot
added
the
6.topic: haskell
ofborg
bot
added
10.rebuild-darwin: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Backport of #336110. Should fix eval on
master. Sorry about this, I didn’t do adequate checking that the references were sufficiently lazy for this to be safe when splitting up the PR.I don’t think this should cause any issues for
haskell-updatesas the commits are a verbatim match between both branches and the two packages these are overrides for are both marked as broken anyway so the overrides were dead code beforehand. If I’m wrong and this does cause any issues forhaskell-updates, I promise I will do my best to do whatever is necessary to resolve them.The alternative, if touching these files on
masteris absolutely verboten, is to revert #336141 until the nexthaskell-updatescycle.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.