Merged
Conversation
This has to be a separate package, because it can't do both.
- kweathercore to gear - kipi removed - knotes removed - kgraphviewer and massif-visualizer added - kdevelop and friends to qt6
K900
requested review from
NickCao,
SuperSandro2000 and
ttuegel
as code owners
Contributor
Author
|
Result of 56 packages marked as broken and skipped:
2 packages failed to build:
1014 packages built:
|
Contributor
Author
|
virtscreen is broken by unrelated Python stuff. |
ofborg
bot
added
8.has: clean-up
ofborg
bot
requested review from
7c6f434c,
LunNova,
carlossless,
ilya-fedin and
mjm
ofborg
bot
added
10.rebuild-darwin: 1-10
LunNova
approved these changes
Aug 22, 2024
mjm
approved these changes
Aug 22, 2024
Contributor
mjm
left a comment
mjm
left a comment
There was a problem hiding this comment.
The things I use normally all built fine, and I quickly checked Dolphin and Kmail and both were working.
carlossless
reviewed
Aug 23, 2024
Contributor
carlossless
left a comment
carlossless
left a comment
There was a problem hiding this comment.
astyle seems to work fine 👍
|
audiotube gives me a few errors: I believe that it also produced these before this was merged, i'm just unsure what exactly is broken. On the readme for the project it notes that qtmultimedia with the gstreamer backend is required, and that's my best guess. The app opens and can browse search for music, but upon starting playback it just stays at 0:00 with no sound. |
Contributor
Author
|
I don't think those errors are actually important, it's just youtube blocking youtube-dl again. |
From my limited testing with the flatpak version of audiotube those errors were not present and the flatpak version played audio just fine. It could be another issue but that's what I have noticed so far. |
Contributor
The errors sound like gstreamer plugins providing videoconvert/audioconvert aren't present |
Contributor
|
It's possible audiotube needs various gst-plugins-* in deps + wrapGAppsHook |
|
That's what I thought as well, I tried adding gst-plugins to the buildInputs and wrapGAppsHook3 to nativeBuildInputs, tried adding dontWrapGApps= true as well. I believe #271922 changed the default backend for qtmultimedia to ffmpeg, there is mention of overriding to enable gstreamer I believe? but I can't really decipher if thats what is required here or how to do it. Still trying to see if I can get it working tonight, appreciate the ideas. |
Contributor
|
maybe try this: nixpkgs/pkgs/by-name/br/brickstore/package.nix Lines 63 to 76 in eb76459 |
|
alright that snippet seems to have got me closer, no errors but still no playback audio. Kind of stumped as to why theres still no audio. There are some errors but they mirror those on the flatpak, and the flatpak plays music just fine.. idk |
Contributor
|
Also, for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
https://kde.org/announcements/gear/24.08.0/
Sheesh.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.