Merged
Conversation
Bitcoin 0.15.1 doesn't build with boost 1.66. I'm hesitant to apply untested patches to software like Bitcoin. Instead I'm forcing the boost dependency to version 1.64 (which is the version listed @ https://github.com/bitcoin/bitcoin/blob/45173fa6fca9537abb0a0554f731d14b9f89c456/doc/dependencies.md). Nothing in applications/altcoins/default.nix was using the boost162 parameter, so I've replaced it with the boost164 parameter.
GrahamcOfBorg
added
10.rebuild-darwin: 1-10
jb55
approved these changes
Jan 9, 2018
fpletz
approved these changes
Jan 11, 2018
Member
fpletz
left a comment
fpletz
left a comment
There was a problem hiding this comment.
LGTM but why assign this to me? I've never touched bitcoin.
Contributor
Author
|
Sorry fpletz. I picked you because you merged 33b7ff9 which was the Bitcoin 0.15.1 update. I'll try to find someone else. |
Member
|
Oh, okay. I thought I should do a more thorough review of this change. Seems fine to merge. Are you not able to merge yourself? You're a member of the org after all. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bitcoin 0.15.1 doesn't build with boost 1.66.
I'm hesitant to apply untested patches to software like Bitcoin.
Instead I'm forcing the boost dependency to version 1.64 (which is the version listed @
https://github.com/bitcoin/bitcoin/blob/45173fa6fca9537abb0a0554f731d14b9f89c456/doc/dependencies.md).
Nothing in applications/altcoins/default.nix was using the boost162 parameter, so I've replaced it with the boost164 parameter.
Motivation for this change
Things done
I've run
test_bitcoinandtest_bitcoin-qt, but that is the extent of testing the executables that I've done for this change.build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)