nixos/kresd: fix systemd dependency cycle#33614
Merged
vcunat merged 1 commit intoNixOS:masterfrom Jan 9, 2018
Merged
Conversation
The unnecessary dependency of sockets.target on kresd.service causes a dependency cycle preventing kresd.service from starting at boot: sockets.target -> kresd.service -> basic.target -> sockets.target
Member
|
❤️ |
Member
|
Hmm, I get the warning but the service always starts anyway. |
vcunat
approved these changes
Jan 9, 2018
vcunat
added a commit
that referenced
this pull request
Jan 9, 2018
The PR was extended with other fixes. All tested by me atop 17.09.
Member
|
🆗 Added a few other improvements. Please, @mention me for anything related to knot-resolver. Feedback is welcome. |
Contributor
Author
|
Thanks for the fast response! |
Contributor
|
Is this going to be backported to 17.09? |
vcunat
pushed a commit
that referenced
this pull request
Jan 31, 2018
The unnecessary dependency of sockets.target on kresd.service causes a dependency cycle preventing kresd.service from starting at boot: sockets.target -> kresd.service -> basic.target -> sockets.target (cherry picked from commit f19d959)
Member
|
Right, done. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
kresd.servicemakessockets.targetdepend on itself causing a dependency cycle:As a result,
kresd.servicewon't start on system boot. This PR fixes that.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)