Skip to content

nixVersions.nix_2_24: 2.24.2 -> 2.24.3#336076

Merged
Mic92 merged 1 commit into
NixOS:masterfrom
philiptaron:nixVersions.nix_2_24.3
Aug 20, 2024
Merged

nixVersions.nix_2_24: 2.24.2 -> 2.24.3#336076
Mic92 merged 1 commit into
NixOS:masterfrom
philiptaron:nixVersions.nix_2_24.3

Conversation

@philiptaron
Copy link
Copy Markdown
Contributor

@philiptaron philiptaron commented Aug 20, 2024

Description of changes

Just the most recently tagged Nix 2.24 release.

Changes: NixOS/nix@2.24.2...2.24.3

The substantial change is for Darwin sandbox (cc @emilazy):

  • NixOS/nix@4e707b8 libstore: fix port binding in __darwinAllowLocalNetworking sandbox

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@philiptaron
Copy link
Copy Markdown
Contributor Author

Result of nixpkgs-review pr 336076 run on x86_64-linux 1

11 packages built:
  • colmena
  • harmonia
  • nil
  • nix-eval-jobs
  • nix-fast-build
  • nix-fast-build.dist
  • nixVersions.latest
  • nixVersions.latest.debug
  • nixVersions.latest.dev
  • nixVersions.latest.doc
  • nixVersions.latest.man

@philiptaron philiptaron requested a review from Mic92 August 20, 2024 14:50
Copy link
Copy Markdown
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Darwin fix is good.

@ofborg ofborg Bot requested review from Artturin, edolstra and lovesegfault August 20, 2024 15:25
@ofborg ofborg Bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 20, 2024
@Mic92
Copy link
Copy Markdown
Member

Mic92 commented Aug 20, 2024

Result of nixpkgs-review pr 336076 run on x86_64-linux 1

11 packages built:
  • colmena
  • harmonia
  • nil
  • nix-eval-jobs
  • nix-fast-build
  • nix-fast-build.dist
  • nixVersions.latest
  • nixVersions.latest.debug
  • nixVersions.latest.dev
  • nixVersions.latest.doc
  • nixVersions.latest.man

@Mic92
Copy link
Copy Markdown
Member

Mic92 commented Aug 20, 2024

Result of nixpkgs-review pr 336076 run on aarch64-linux 1

11 packages built:
  • colmena
  • harmonia
  • nil
  • nix-eval-jobs
  • nix-fast-build
  • nix-fast-build.dist
  • nixVersions.latest (nixVersions.nix_2_24)
  • nixVersions.latest.debug (nixVersions.nix_2_24.debug)
  • nixVersions.latest.dev (nixVersions.nix_2_24.dev)
  • nixVersions.latest.doc (nixVersions.nix_2_24.doc)
  • nixVersions.latest.man (nixVersions.nix_2_24.man)

@Mic92 Mic92 merged commit 53659de into NixOS:master Aug 20, 2024
@JohnRTitor
Copy link
Copy Markdown
Member

Isn't the @NixOS/nix-team is supposed to be "code owner" rather than RaitoBezarius?

@Mic92
Copy link
Copy Markdown
Member

Mic92 commented Aug 21, 2024

Isn't the @NixOS/nix-team is supposed to be "code owner" rather than RaitoBezarius?

Yes. See #314065 (comment)

@github-actions
Copy link
Copy Markdown
Contributor

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-336076-to-release-24.05 origin/release-24.05
cd .worktree/backport-336076-to-release-24.05
git switch --create backport-336076-to-release-24.05
git cherry-pick -x 0669be90824575c6dde136f52032538b6ae19a69

@philiptaron
Copy link
Copy Markdown
Contributor Author

Backport already complete in #336108 @roberth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants