webcord-vencord: electron_29 -> electron_30#335876
Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom Aug 20, 2024
Merged
webcord-vencord: electron_29 -> electron_30#335876SuperSandro2000 merged 1 commit intoNixOS:masterfrom
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
Conversation
22 tasks
yayayayaka
approved these changes
Aug 20, 2024
Member
yayayayaka
left a comment
There was a problem hiding this comment.
Tested on x86_64, app starts as intended and Vencord works as expected. No
crashes/undesirable behaviour observed.
Can confirm, looking good for me.
1 task
Contributor
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Changes
webcord-vencord's electron version to electron 30 as electron 29 isalmost EoL. Should address #335850.
Tested on x86_64, app starts as intended and Vencord works as expected. No
crashes/undesirable behaviour observed. Further testing appreciated.
Things done
nix.conf? (SeeNix manual)
sandbox = relaxedsandbox = true(look inside
nixos/tests)
package tests
lib/tests or
pkgs/test
linked
to the relevant packages
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: allchanges have to be committed, also see
nixpkgs-review usage
./result/bin/)(or backporting
23.11
and
24.05
Release notes)
breaking
significant
module
CONTRIBUTING.md.
Add a 👍 reaction to pull requests you find important.