Skip to content

Comments

webcord-vencord: electron_29 -> electron_30#335876

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
NotAShelf:webcord-vencord-e30
Aug 20, 2024
Merged

webcord-vencord: electron_29 -> electron_30#335876
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
NotAShelf:webcord-vencord-e30

Conversation

@NotAShelf
Copy link
Member

@NotAShelf NotAShelf commented Aug 19, 2024

Description of changes

Changes webcord-vencord's electron version to electron 30 as electron 29 is
almost EoL. Should address #335850.

Tested on x86_64, app starts as intended and Vencord works as expected. No
crashes/undesirable behaviour observed. Further testing appreciated.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See
    Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using
    nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all
    changes have to be committed, also see
    nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in
    ./result/bin/)
  • 24.11 Release Notes
    (or backporting
    23.11
    and
    24.05
    Release notes)
    • (Package updates) Added a release notes entry if the change is major or
      breaking
    • (Module updates) Added a release notes entry if the change is
      significant
    • (Module addition) Added a release notes entry if adding a new NixOS
      module
  • Fits
    CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 19, 2024
Copy link
Member

@yayayayaka yayayayaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on x86_64, app starts as intended and Vencord works as expected. No
crashes/undesirable behaviour observed.

Can confirm, looking good for me.

@github-actions
Copy link
Contributor

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants