nixos/timesyncd: default explicit config to the empty list#335802
Closed
flokli wants to merge 1 commit intoNixOS:masterfrom
Closed
nixos/timesyncd: default explicit config to the empty list#335802flokli wants to merge 1 commit intoNixOS:masterfrom
flokli wants to merge 1 commit intoNixOS:masterfrom
Conversation
This allows systemd-timesyncd to use NTP servers advertised via DHCP.
Our current approach effectively hardcodes them to
`{0..4}.nixos.pool.ntp.org`.
Closes NixOS#335050.
github-actions
bot
added
6.topic: nixos
doronbehar
approved these changes
Aug 19, 2024
Contributor
doronbehar
left a comment
doronbehar
left a comment
There was a problem hiding this comment.
Changes look good. Haven't tested, and I don't think it should be critical to test this. (I'm also not sure how to test this).
datafoo
reviewed
Aug 19, 2024
| default = config.networking.timeServers; | ||
| defaultText = literalExpression "config.networking.timeServers"; | ||
| default = [ ]; | ||
| defaultText = literalExpression "[]"; |
Contributor
There was a problem hiding this comment.
Is this necessary to use defaultText with such value?
ofborg
bot
added
10.rebuild-darwin: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows systemd-timesyncd to use NTP servers advertised via DHCP. Our current approach effectively hardcodes them to
{0..4}.nixos.pool.ntp.org.Closes #335050.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.