Heroic Games Launcher: 2.14.1 -> 2.15.1#335737
Heroic Games Launcher: 2.14.1 -> 2.15.1#335737K900 merged 2 commits intoNixOS:masterfrom aidalgol:heroic-2.15
Conversation
ofborg
bot
added
8.has: clean-up
ofborg
bot
added
10.rebuild-darwin: 11-100
|
PR #333907 has been merged, this can be rebased. |
pkgs/games/heroic/default.nix
Outdated
There was a problem hiding this comment.
Did this regress with this update? If so fine for me. If it theoretically could still work and you just didn't test it, please keep the platform here.
There was a problem hiding this comment.
There was a change to the upstream build that puts x64 in the path to the helper binaries, so it looks as if they are starting to hard-code assumptions about the platform. As for ARM Linux and Darwin in general, Heroic may theoretically run, but any game you try to launch almost certainly will not, and that is the entire point of the application.
|
Result of 2 packages built:
|
yayayayaka
left a comment
yayayayaka
left a comment
There was a problem hiding this comment.
nixpkgs-review happy and application is launching. Looking fine by me.
ofborg
bot
added
11.by: package-maintainer
wegank
added
the
12.approvals: 1
|
Result of 2 packages built:
|
|
Runs as expected and games seem to run as well (only tested a few). |
|
Successfully created backport PR for |
8 participants
Description of changes
Update Heroic Games Launcher to latest release.
Rolled #327273 into this PR.
Narrows
meta.platformsto only x86_64 Linux. For Linux, only x86_64 is supported by upstream, and for nix-darwin, this really needs a dedicated maintainer. It will also probably not work well compared to using upstream's macOS build. This package is really only meant for NixOS. If you are on another operating system, using this nix package will be more trouble than using an official build, or an unofficial package specifically for your platform.Closes #333956.
Supersedes #327273
Fixes #327153
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.