wechat-uos: fix crashing issue caused by zerocallusedregs hardening#335658
Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom Aug 19, 2024
Merged
wechat-uos: fix crashing issue caused by zerocallusedregs hardening#335658Aleksanaa merged 1 commit intoNixOS:masterfrom
Aleksanaa merged 1 commit intoNixOS:masterfrom
Conversation
Cryolitia
approved these changes
Aug 18, 2024
Member
Cryolitia
left a comment
Cryolitia
left a comment
There was a problem hiding this comment.
Good work!
test on x86_64-linux
Cryolitia
added
the
12.approvals: 1
UlyssesZh
approved these changes
Aug 18, 2024
Member
UlyssesZh
left a comment
UlyssesZh
left a comment
There was a problem hiding this comment.
Thank you for this PR, and also thank @Cryolitia for finding out the cause of the problem.
ofborg
bot
added
11.by: package-maintainer
pokon548
approved these changes
Aug 19, 2024
pokon548
added
12.approvals: 2
Cryolitia
added
12.approvals: 3+
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The hardening flag
zerocallusedregsenabled by default in #316761 caused incompatibility with WeChat's binary file. WeChat would crash in a series ofpthreadcalls.Overriding the glibc in the FHS with one compiled without the
zerocallusedregsfixes the issue.Immense thanks to @Cryolitia for spending a ton of compute resources and time on bisecting the issue.
Fixes #327860
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.