luminous-ttv: init at 0.5.7#335481
Conversation
SigmaSquadron
left a comment
There was a problem hiding this comment.
Please format the changed files with nixfmt-rfc-style and set your editorconfig settings to add a newline at the end of the file.
(See CONTRIBUTING.md#syntax)
There was a problem hiding this comment.
| rev = "v{version}"; | |
| rev = "v${version}"; |
There was a problem hiding this comment.
| homepage = "https://github.com/AlyoshaVasilieva/{pname}"; | |
| downloadPage = "https://github.com/AlyoshaVasilieva/{pname}/releases/latest"; | |
| changelog = "https://github.com/AlyoshaVasilieva/{pname}/releases/tag/v{version}"; | |
| homepage = "https://github.com/AlyoshaVasilieva/${pname}"; | |
| downloadPage = "https://github.com/AlyoshaVasilieva/${pname}/releases/latest"; | |
| changelog = "https://github.com/AlyoshaVasilieva/${pname}/releases/tag/v${version}"; |
There was a problem hiding this comment.
Better: do not use "${pname}"
SigmaSquadron
left a comment
There was a problem hiding this comment.
Please squash the "follow code conventions" commit into the main init one. There should only be two commits for this PR: your maintainership one, and the package initialisation.
There was a problem hiding this comment.
| description = "A Rust server to retrieve and relay a playlist for Twitch livestreams/VODs."; | |
| description = "Rust server to retrieve and relay a playlist for Twitch livestreams/VODs"; |
The description should not begin with an article nor end with punctuation.
|
I tried to squash the commits into one, but clearly I failed. I'm not well-versed in using git. |
|
No need. The easiest way to do this (without rebasing) is to reset your changes and re-commit. Run the following: git reset --soft HEAD~3 # This will undo the last three commits, including the original init one.
git commit -m "luminous-ttv: init at 0.5.7" -s -S # Commit all changes together.
# Use `git log` to ascertain that your commits are correct.
# Mark this PR as a draft before pushing as a final safety net.
git push --force-with-lease # Push your changes while rewriting the commit history.
# Mark your PR as ready to review if nothing exploded. |
aa07c80 to
a9fb62f
Compare
AndersonTorres
left a comment
There was a problem hiding this comment.
Result of nixpkgs-review pr 335481 run on x86_64-linux 1
1 package built:
- luminous-ttv
Description of changes
Add new package: luminous-ttv
A Rust server to retrieve and relay a playlist for Twitch livestreams/VODs.
Homepage URL: https://github.com/AlyoshaVasilieva/luminous-ttv
Licenses: GPL-3.0-Only, MIT
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.