Skip to content

Comments

luminous-ttv: init at 0.5.7#335481

Merged
Aleksanaa merged 2 commits intoNixOS:masterfrom
alexanderjkslfj:luminous-ttv
Oct 29, 2024
Merged

luminous-ttv: init at 0.5.7#335481
Aleksanaa merged 2 commits intoNixOS:masterfrom
alexanderjkslfj:luminous-ttv

Conversation

@alexanderjkslfj
Copy link
Contributor

Description of changes

Add new package: luminous-ttv
A Rust server to retrieve and relay a playlist for Twitch livestreams/VODs.

Homepage URL: https://github.com/AlyoshaVasilieva/luminous-ttv
Licenses: GPL-3.0-Only, MIT

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Aug 17, 2024
@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Aug 17, 2024
Copy link
Contributor

@SigmaSquadron SigmaSquadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format the changed files with nixfmt-rfc-style and set your editorconfig settings to add a newline at the end of the file.

(See CONTRIBUTING.md#syntax)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rev = "v{version}";
rev = "v${version}";

Comment on lines 18 to 20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
homepage = "https://github.com/AlyoshaVasilieva/{pname}";
downloadPage = "https://github.com/AlyoshaVasilieva/{pname}/releases/latest";
changelog = "https://github.com/AlyoshaVasilieva/{pname}/releases/tag/v{version}";
homepage = "https://github.com/AlyoshaVasilieva/${pname}";
downloadPage = "https://github.com/AlyoshaVasilieva/${pname}/releases/latest";
changelog = "https://github.com/AlyoshaVasilieva/${pname}/releases/tag/v${version}";

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better: do not use "${pname}"

#278611

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 18, 2024
Copy link
Contributor

@SigmaSquadron SigmaSquadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the "follow code conventions" commit into the main init one. There should only be two commits for this PR: your maintainership one, and the package initialisation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = "A Rust server to retrieve and relay a playlist for Twitch livestreams/VODs.";
description = "Rust server to retrieve and relay a playlist for Twitch livestreams/VODs";

The description should not begin with an article nor end with punctuation.

@alexanderjkslfj
Copy link
Contributor Author

I tried to squash the commits into one, but clearly I failed. I'm not well-versed in using git.
Instead of trying again I think it's easier to just cancel this PR and to start a fresh one where I do it correctly from the start.

@SigmaSquadron
Copy link
Contributor

SigmaSquadron commented Aug 18, 2024

No need. The easiest way to do this (without rebasing) is to reset your changes and re-commit.

Run the following:

git reset --soft HEAD~3 # This will undo the last three commits, including the original init one.
git commit -m "luminous-ttv: init at 0.5.7" -s -S # Commit all changes together.
# Use `git log` to ascertain that your commits are correct.
# Mark this PR as a draft before pushing as a final safety net.
git push --force-with-lease # Push your changes while rewriting the commit history.
# Mark your PR as ready to review if nothing exploded.

@alexanderjkslfj alexanderjkslfj marked this pull request as draft August 19, 2024 14:32
@alexanderjkslfj alexanderjkslfj marked this pull request as ready for review August 19, 2024 17:50
Copy link
Contributor

@SigmaSquadron SigmaSquadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 20, 2024
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 335481 run on x86_64-linux 1

1 package built:
  • luminous-ttv

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Aug 31, 2024
@Aleksanaa Aleksanaa merged commit e3976fc into NixOS:master Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants