Skip to content

Comments

kakounePlugins.kakoune-lsp: 17.1.1 -> 17.1.2 (fix build)#335266

Merged
philiptaron merged 1 commit intoNixOS:masterfrom
philiptaron:issue-332957/fix-kakoune-lsp
Aug 17, 2024
Merged

kakounePlugins.kakoune-lsp: 17.1.1 -> 17.1.2 (fix build)#335266
philiptaron merged 1 commit intoNixOS:masterfrom
philiptaron:issue-332957/fix-kakoune-lsp

Conversation

@philiptaron
Copy link
Contributor

@philiptaron philiptaron commented Aug 16, 2024

Description of changes

Fixes the build for Rust 1.80.0 (#332957).

Closes #335251.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@philiptaron philiptaron requested a review from L-as August 16, 2024 23:33
@philiptaron philiptaron mentioned this pull request Aug 16, 2024
13 tasks
@philiptaron philiptaron marked this pull request as draft August 17, 2024 00:55
@philiptaron
Copy link
Contributor Author

17.1.2 is out; updating this PR. 🎽

@philiptaron philiptaron force-pushed the issue-332957/fix-kakoune-lsp branch from 6266db1 to 096157a Compare August 17, 2024 00:59
@philiptaron philiptaron changed the title kakounePlugins.kakoune-lsp: 17.1.1 -> 17.1.1-unstable-2024-08-16 kakounePlugins.kakoune-lsp: 17.1.1 -> 17.1.2 (fix build) Aug 17, 2024
@philiptaron philiptaron marked this pull request as ready for review August 17, 2024 01:00
@dblsaiko
Copy link
Contributor

Closes #335251 (I hope that works if you add it as a comment)

Copy link
Contributor

@dblsaiko dblsaiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 335266 run on x86_64-linux 1

1 package built:
  • kakoune-lsp

@philiptaron philiptaron merged commit 6695cea into NixOS:master Aug 17, 2024
@philiptaron philiptaron deleted the issue-332957/fix-kakoune-lsp branch August 17, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: kak-lsp

2 participants