-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
Low-impact cross fixes, batch 2 #33480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
9f064cc
a37a8d9
519cfff
492bf45
f8e1635
cbfaf2e
df7d697
006febd
0214771
5e3b605
46e58bd
2bdaa07
47bd982
f866587
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,7 +8,10 @@ stdenv.mkDerivation rec { | |
| url = "mirror://sourceforge/omxil/omxil/Bellagio%20${version}/${name}.tar.gz"; | ||
| sha256 = "0k6p6h4npn8p1qlgq6z3jbfld6n1bqswzvxzndki937gr0lhfg2r"; | ||
| }; | ||
|
|
||
|
|
||
| configureFlags = | ||
| stdenv.lib.optionals (stdenv.hostPlatform != stdenv.buildPlatform) [ "ac_cv_func_malloc_0_nonnull=yes" ]; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same might not be needed |
||
|
|
||
| patches = [ ./fedora-fixes.patch ]; | ||
|
|
||
| meta = with stdenv.lib; { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,7 +15,7 @@ stdenv.mkDerivation rec { | |
|
|
||
| configureFlags = stdenv.lib.optional stdenv.isArm "--disable-arm-iwmmxt"; | ||
|
|
||
| doCheck = true; | ||
| doCheck = stdenv.hostPlatform == stdenv.buildPlatform; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Again stdenv should be changed to cope with this.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should it? It's not clear to me that |
||
|
|
||
| postInstall = glib.flattenInclude; | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,11 +2,12 @@ perl: | |
|
|
||
| { buildInputs ? [], name, ... } @ attrs: | ||
|
|
||
| perl.stdenv.mkDerivation ( | ||
| with perl.stdenv; | ||
| mkDerivation ( | ||
| { | ||
| outputs = [ "out" "devdoc" ]; | ||
|
|
||
| doCheck = true; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Again for stdenv to handle. |
||
| doCheck = hostPlatform == buildPlatform; | ||
|
|
||
| checkTarget = "test"; | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,7 @@ stdenv.mkDerivation { | |
|
|
||
| src = kernel.src; | ||
|
|
||
| nativeBuildInputs = [ gettext ]; | ||
| buildInputs = [ coreutils pciutils gettext ]; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Gettext need not be build input, I'd think? |
||
|
|
||
| configurePhase = '' | ||
|
|
@@ -15,7 +16,7 @@ stdenv.mkDerivation { | |
| ''; | ||
|
|
||
| buildPhase = '' | ||
| make | ||
| make CROSS=${stdenv.cc.targetPrefix} | ||
| ''; | ||
|
|
||
| installPhase = '' | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we're checking things. I found I needed a lot less of these configure test overrides than @bgamari, so maybe pull this out initially?