emacs: replace cd with pushd/popd in buildPhase of melpaBuild#334692
Merged
jian-lin merged 3 commits intoNixOS:stagingfrom Aug 15, 2024
Merged
emacs: replace cd with pushd/popd in buildPhase of melpaBuild#334692jian-lin merged 3 commits intoNixOS:stagingfrom
jian-lin merged 3 commits intoNixOS:stagingfrom
Conversation
The default value is false.
It is better to not change the working directory. One example showing the benefit is the rewriting[1] of lspce, where the Rust build hook assumes the working directory is unchanged. [1]: NixOS#334476
ofborg
bot
added
10.rebuild-darwin: 501+
AndersonTorres
approved these changes
Aug 15, 2024
Member
AndersonTorres
left a comment
AndersonTorres
left a comment
There was a problem hiding this comment.
A nice improvement, and way easier to reason about.
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
It is better to not change the working directory.
One example showing the benefit is the rewriting1 of lspce, where
the Rust build hook assumes the working directory is unchanged.
Due to the limitation of nix, this PR triggers rebuilds of all packages built with
melpaBuild. However, it only affects a small number of package which changes their working directory. I use a heuristic way to find those packages: searching forcd,source,packages,recipes,working,..,pushdandpopd.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.