nixos/README.md: relax the requirement of providing option defaults#334509
Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom Jan 15, 2025
Merged
Conversation
Member
Author
|
motivating example |
37e9098 to
e840f5b
Compare
Aleksanaa
reviewed
Dec 4, 2024
nixos/README.md
Outdated
Member
There was a problem hiding this comment.
Suggested change
| - Defaults may only be omitted if: (1) the user configuring them is required and (2) they are not used/block evaluation when the the module is not enabled. | |
| - Defaults may only be omitted if: | |
| 1. the user configuring them is required | |
| 2. they are not used/block evaluation when the the module is not enabled |
Style suggestion
e840f5b to
8813c61
Compare
If we enforce the requirement of option defaults to the extreme, then we end up with silly sentinel values, a bunch of nullable types, and assertions checking for sentinel values.
8813c61 to
959155e
Compare
Aleksanaa
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we enforce the requirement of option defaults to the extreme, then we end up with silly sentinel values, a bunch of nullable types, and assertions checking for sentinel values.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.