Skip to content

python312Packages.pymupdf: mark as broken#334318

Closed
GaetanLepage wants to merge 1 commit intoNixOS:masterfrom
GaetanLepage:mupdf
Closed

python312Packages.pymupdf: mark as broken#334318
GaetanLepage wants to merge 1 commit intoNixOS:masterfrom
GaetanLepage:mupdf

Conversation

@GaetanLepage
Copy link
Contributor

Description of changes

The overriden C++ mupdf doesn't build

Traceback (most recent call last):
    scripts/mupdfwrap.py:6:<module>(): wrap.__main__.main()
    scripts/wrap/__main__.py:2902:main(): jlib.exception_info()
    ^except raise:
    scripts/wrap/__main__.py:2900:main(): main2()
    scripts/wrap/__main__.py:2310:main2(): build( build_dirs, swig_command, args, vs_upgrade)
    scripts/wrap/__main__.py:1638:build(): jlib.build(
    scripts/jlib.py:2213:build(): system( command, out=out, verbose=verbose, executable=executable, caller=2)
    scripts/jlib.py:1682:system(): raise Exception( message)
Exception: Command failed: c++ \
    -o build/shared-release/libmupdfcpp.so \
 \
    -O2 -DNDEBUG \
    -fPIC -shared \
    -I /build/mupdf-1.23.6-source/include \
    -I /build/mupdf-1.23.6-source/platform/c++/include \
     platform/c++/implementation/classes.cpp platform/c++/implementation/classes2.cpp platform/c++/implementation/exceptions.cpp platform/c++/implementation/extra.cpp platform/c++/i>
    -L build/shared-release -l mupdf -Wl,-rpath,'$ORIGIN',-z,origin

cc @teto

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 13, 2024
@fabaff
Copy link
Member

fabaff commented Aug 13, 2024

See #332385

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 13, 2024
@GaetanLepage
Copy link
Contributor Author

See #332385

Thanks for the pointer.
However, I would recommend to mark it as broken in the meantime to avoid polluting nixpkgs-review reports.

@SuperSandro2000
Copy link
Member

If we already have a fix PR which is likely merged soon, we don't need to throw the author a merge conflict into the wheels.

Closing in favor of #332385

@GaetanLepage
Copy link
Contributor Author

If we already have a fix PR which is likely merged soon, we don't need to throw the author a merge conflict into the wheels.

Indeed, this makes sense.

@GaetanLepage GaetanLepage deleted the mupdf branch August 14, 2024 14:18
@GaetanLepage
Copy link
Contributor Author

@teto pymupdf is again failing on master (and has been for at least a few days by now).
Do you mind if we mark it as broken to prevent useless nixpkgs-review pollution ?

@teto
Copy link
Member

teto commented Sep 15, 2024

yeah np, it needs a new maintainer I've stopped using it :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants