Skip to content

Comments

kakoune-lsp: 16.0.0 -> 17.1.1#334188

Closed
liclac wants to merge 1 commit intoNixOS:masterfrom
liclac:kakoune-lsp-17.1.1
Closed

kakoune-lsp: 16.0.0 -> 17.1.1#334188
liclac wants to merge 1 commit intoNixOS:masterfrom
liclac:kakoune-lsp-17.1.1

Conversation

@liclac
Copy link
Contributor

@liclac liclac commented Aug 12, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from philiptaron August 12, 2024 18:10
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 12, 2024
@philiptaron
Copy link
Contributor

See also #302761. I'm going to review that one first.

@philiptaron philiptaron added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 14, 2024
@L-as
Copy link
Member

L-as commented Aug 16, 2024

I think this has been made redundant

@liclac
Copy link
Contributor Author

liclac commented Aug 16, 2024

Ye

@liclac liclac closed this Aug 16, 2024
@liclac liclac deleted the kakoune-lsp-17.1.1 branch August 16, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants