Skip to content

Revert "pkgs/top-level/config.nix: nixfmt, declare options"#332524

Merged
philiptaron merged 1 commit intomasterfrom
revert-330753-nixpkgs-declare-options
Aug 5, 2024
Merged

Revert "pkgs/top-level/config.nix: nixfmt, declare options"#332524
philiptaron merged 1 commit intomasterfrom
revert-330753-nixpkgs-declare-options

Conversation

@eclairevoyant
Copy link
Contributor

Reverts #330753 due to master breakage; will need a new PR and testing in the future.

CC @philiptaron

@github-actions github-actions bot added the 6.topic: stdenv Standard environment label Aug 5, 2024
@philiptaron philiptaron self-requested a review August 5, 2024 16:47
@philiptaron
Copy link
Contributor

The failing test is here: #330753 (comment)

@philiptaron
Copy link
Contributor

I think it's fine to merge a revert even if the CI fails. @eclairevoyant, did you generate this commit with git revert or manually?

@philiptaron philiptaron merged commit fb7d848 into master Aug 5, 2024
@philiptaron
Copy link
Contributor

I validated using nixpkgs-review and nixpkgs-manual and the test case provided.

@philiptaron
Copy link
Contributor

@spiage is master fine for you now?

@spiage
Copy link

spiage commented Aug 5, 2024

Yes =)

Version 15449 -> 15450:
  nixos-system-a7: 24.11.20240805.6be7a53 → 24.11.20240805.fb7d848
  source: +14.1 KiB

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 5, 2024
@philiptaron philiptaron deleted the revert-330753-nixpkgs-declare-options branch August 5, 2024 17:22
@alyssais
Copy link
Member

alyssais commented Aug 5, 2024

Please include reasons for reverts in commit messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: stdenv Standard environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants