Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cypress: 13.2.0 -> 13.13.2 #332513

Merged
merged 1 commit into from
Aug 5, 2024
Merged

cypress: 13.2.0 -> 13.13.2 #332513

merged 1 commit into from
Aug 5, 2024

Conversation

lukas-mertens
Copy link
Contributor

@lukas-mertens lukas-mertens commented Aug 5, 2024

Description of changes

Updated Cypress from 13.2.0 to 13.13.2. Basically the current version on 13.2.0 is broken as well as it actually builds with a 12.x binary which is even more outdated. So this is fixed here as well.

Cypress Changelog:
https://docs.cypress.io/guides/references/changelog

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.
    => at least I hope so :)

Fixes #332313


Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Aug 5, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Aug 5, 2024
@Craftzman7 Craftzman7 added needs_merger 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Aug 5, 2024
@donovanglover donovanglover mentioned this pull request Aug 5, 2024
13 tasks
Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Looks like the update bot hasn't been updating the aarch64 hash for a while now, and that aarch64 support was added after the update script was made, which broke it.

I'll go ahead and merge this, but long-term we should fix the update script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12. first-time contribution This PR is the author's first one; please be gentle! needs_merger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update request: cypress 13.2.0 → 13.13.2
4 participants