Skip to content

brscan5: remove deprecated SYSFS udev rule#332311

Merged
r-vdp merged 1 commit intoNixOS:masterfrom
mattchrist:brscan5-remove-sysfs
May 20, 2025
Merged

brscan5: remove deprecated SYSFS udev rule#332311
r-vdp merged 1 commit intoNixOS:masterfrom
mattchrist:brscan5-remove-sysfs

Conversation

@mattchrist
Copy link
Contributor

@mattchrist mattchrist commented Aug 4, 2024

Description of changes

This patch resolves an issue where systemd-udevd outputs events like:

/nix/store/jm9paymkapbi6pzwbjgmi634vaf2y5va-udev-rules/49-brother-mfp-brscan5-1.0.2-2.rules:17 Invalid key 'SYSFS'.

Fixes #332307

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Aug 4, 2024
@mattchrist mattchrist changed the title brscan5: remove upstream's use of deprecated SYSFS udev rule brscan5: remove deprecated SYSFS udev rule Aug 4, 2024
@mattchrist mattchrist force-pushed the brscan5-remove-sysfs branch 2 times, most recently from 3b75a63 to 8286def Compare August 4, 2024 18:45
@mattchrist mattchrist added 8.has: package (update) This PR updates a package to a newer version 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 8.has: tests This PR has tests labels Aug 4, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 4, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 9, 2024
@jcaesar
Copy link
Contributor

jcaesar commented May 14, 2025

@mattchrist: Would you mind renovating this? I think the udevadm verify executed during udev rule build started failing from the SYSFS rule, so it'd be nice to get this merged…

@mattchrist
brscan5: remove deprecated SYSFS udev rule
ff62fe4 
This patch resolves an issue where systemd-udevd outputs events like:

/nix/store/jm9paymkapbi6pzwbjgmi634vaf2y5va-udev-rules/49-brother-mfp-brscan5-1.0.2-2.rules:17 Invalid key 'SYSFS'.
@mattchrist mattchrist force-pushed the brscan5-remove-sysfs branch from 8286def to ff62fe4 Compare May 14, 2025 23:01
@mattchrist mattchrist removed the 2.status: merge conflict This PR has merge conflicts with the target branch label May 14, 2025
keenanweaver
keenanweaver approved these changes May 15, 2025
View reviewed changes
Copy link
Member

@keenanweaver keenanweaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 332311

x86_64-linux

✅ 1 package built:
  • brscan5

@keenanweaver keenanweaver added the 12.approvals: 1 This PR was reviewed and approved by one person. label May 15, 2025
@nixos-discourse
Copy link

nixos-discourse commented May 16, 2025

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2382

@teutat3s teutat3s added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels May 17, 2025
@mattchrist mattchrist mentioned this pull request May 19, 2025
Closed
@teutat3s teutat3s added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels May 20, 2025
LordGrimmauld
LordGrimmauld approved these changes May 20, 2025
View reviewed changes
Copy link
Contributor

@LordGrimmauld LordGrimmauld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw this (in fact, it was my testing base for #407629...), but i never did press approve, did i....

But sorry, can't merge, not a committer...

@LordGrimmauld LordGrimmauld mentioned this pull request May 20, 2025
Closed
3 tasks
@r-vdp
Copy link
Contributor

r-vdp commented May 20, 2025

Let's get this in to unbreak people's systems, and then we can have it use the new setup hook in a follow up PR.

@r-vdp r-vdp merged commit a9746f1 into NixOS:master May 20, 2025
23 of 24 checks passed
r-vdp
r-vdp reviewed May 20, 2025
View reviewed changes
nixos/tests/brscan5.nix

# Confirm systemd-udevd no longer logs errors about SYSFS
logs = machine.succeed('journalctl --unit systemd-udevd')
assert "Invalid key 'SYSFS'" not in logs
Copy link
Contributor

@r-vdp r-vdp May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can now be replaced by adding the new udev setup hook to the derivation's native build inputs.
See #407629

@leana8959
Copy link
Contributor

leana8959 commented May 21, 2025

I'm glad to see this fixed! Thank you for the work.

I'm not seeing the change being backported to 25.05 and it's still broken in the upcoming release, will it be backported?

@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented May 21, 2025

Successfully created backport PR for release-25.05:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request May 21, 2025
Merged
1 task
@nixpkgs-ci nixpkgs-ci bot added the 8.has: port to stable This PR already has a backport to the stable release. label May 21, 2025
@r-vdp
Copy link
Contributor

r-vdp commented May 21, 2025

I'm glad to see this fixed! Thank you for the work.

I'm not seeing the change being backported to 25.05 and it's still broken in the upcoming release, will it be backported?

Right, thanks for bringing that up, I added the label now so the bot should create the backport PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@r-vdp r-vdp r-vdp left review comments

@teutat3s teutat3s teutat3s approved these changes

@LordGrimmauld LordGrimmauld LordGrimmauld approved these changes

+2 more reviewers

@hughobrien hughobrien hughobrien approved these changes

@keenanweaver keenanweaver keenanweaver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: package (update) This PR updates a package to a newer version 8.has: port to stable This PR already has a backport to the stable release. 8.has: tests This PR has tests 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

brscan5's udev rule contains deprecated key "SYSFS"

10 participants

@mattchrist @jcaesar @nixos-discourse @r-vdp @leana8959 @hughobrien @teutat3s @keenanweaver @LordGrimmauld @wegank