Skip to content

python3Packages.ffmpeg-python: 0.2.0 -> 0.2.0-unstable-2022-07-11; patch out future dependency; add patches for FFmpeg 7#332111

Merged
pbsds merged 5 commits intoNixOS:masterfrom
emilazy:push-qwxmuspvpmlw
Aug 11, 2024
Merged

python3Packages.ffmpeg-python: 0.2.0 -> 0.2.0-unstable-2022-07-11; patch out future dependency; add patches for FFmpeg 7#332111
pbsds merged 5 commits intoNixOS:masterfrom
emilazy:push-qwxmuspvpmlw

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Aug 4, 2024

Description of changes

I think it’s cool when the number of things that depend on FFmpeg 4 goes down.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 4, 2024
@ofborg ofborg bot requested a review from AluisioASG August 4, 2024 00:52
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 4, 2024
@emilazy emilazy force-pushed the push-qwxmuspvpmlw branch from e9338bd to a67b434 Compare August 9, 2024 22:05
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Aug 9, 2024
@gador
Copy link
Member

gador commented Aug 10, 2024

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 332111 run on x86_64-linux 1

18 packages built:
  • backgroundremover
  • backgroundremover.dist
  • ffsubsync
  • ffsubsync.dist
  • miniplayer
  • miniplayer.dist
  • python311Packages.ffmpeg-python
  • python311Packages.ffmpeg-python.dist
  • python311Packages.reolink
  • python311Packages.reolink.dist
  • python312Packages.ffmpeg-python
  • python312Packages.ffmpeg-python.dist
  • python312Packages.reolink
  • python312Packages.reolink.dist
  • r128gain
  • r128gain.dist
  • ytmdl
  • ytmdl.dist

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

Details ffsubsync.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

ffsubsync:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

r128gain.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

r128gain:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

@gador
Copy link
Member

gador commented Aug 10, 2024

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 332111 run on aarch64-darwin 1

18 packages built:
  • backgroundremover
  • backgroundremover.dist
  • ffsubsync
  • ffsubsync.dist
  • miniplayer
  • miniplayer.dist
  • python311Packages.ffmpeg-python
  • python311Packages.ffmpeg-python.dist
  • python311Packages.reolink
  • python311Packages.reolink.dist
  • python312Packages.ffmpeg-python
  • python312Packages.ffmpeg-python.dist
  • python312Packages.reolink
  • python312Packages.reolink.dist
  • r128gain
  • r128gain.dist
  • ytmdl
  • ytmdl.dist

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

Details ffsubsync.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

ffsubsync:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

r128gain.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

r128gain:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 10, 2024
@pbsbot
Copy link

pbsbot commented Aug 11, 2024

Result of nixpkgs-review pr 332111 run on x86_64-linux 1

18 packages built:
  • backgroundremover
  • backgroundremover.dist
  • ffsubsync
  • ffsubsync.dist
  • miniplayer
  • miniplayer.dist
  • python311Packages.ffmpeg-python
  • python311Packages.ffmpeg-python.dist
  • python311Packages.reolink
  • python311Packages.reolink.dist
  • python312Packages.ffmpeg-python
  • python312Packages.ffmpeg-python.dist
  • python312Packages.reolink
  • python312Packages.reolink.dist
  • r128gain
  • r128gain.dist
  • ytmdl
  • ytmdl.dist

@pbsds pbsds merged commit 129f579 into NixOS:master Aug 11, 2024
@emilazy emilazy mentioned this pull request Aug 21, 2024
Merged
13 tasks
@emilazy emilazy deleted the push-qwxmuspvpmlw branch August 26, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gador gador gador approved these changes

@AluisioASG AluisioASG Awaiting requested review from AluisioASG

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@emilazy @gador @pbsbot @pbsds @wegank

Comments