Skip to content

Comments

libextractor: 1.11 -> 1.13#332051

Merged
wegank merged 1 commit intoNixOS:masterfrom
emilazy:push-suprwomxyvrm
Aug 10, 2024
Merged

libextractor: 1.11 -> 1.13#332051
wegank merged 1 commit intoNixOS:masterfrom
emilazy:push-suprwomxyvrm

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Aug 3, 2024

Description of changes

Upstream dropped FFmpeg support, which is convenient for my current quest, as they were stuck on FFmpeg 4.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Upstream dropped FFmpeg support, which is convenient for my current
quest, as they were stuck on FFmpeg 4.
@ofborg ofborg bot requested a review from jorsn August 3, 2024 19:35
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 3, 2024
@donovanglover
Copy link
Member

Result of nixpkgs-review pr 332051 run on x86_64-linux 1

9 packages built:
  • challenger
  • doodle
  • gnunet
  • gnunet-gtk
  • libextractor
  • sync
  • taler-exchange
  • taler-merchant
  • vdrPlugins.xineliboutput

Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@donovanglover donovanglover requested a review from wegank August 9, 2024 19:56
@wegank
Copy link
Member

wegank commented Aug 10, 2024

Result of nixpkgs-review pr 332051 run on aarch64-darwin 1

1 package marked as broken and skipped:
  • gnunet-gtk
2 packages built:
  • gnunet
  • libextractor

@wegank wegank merged commit f85a800 into NixOS:master Aug 10, 2024
@emilazy emilazy mentioned this pull request Aug 21, 2024
13 tasks
@emilazy emilazy deleted the push-suprwomxyvrm branch August 26, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants