Skip to content

doc: Breaking change release note for bintools-wrapper#33196

Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom
obsidiansystems:bintools-release-note
Dec 31, 2017
Merged

doc: Breaking change release note for bintools-wrapper#33196
Ericson2314 merged 1 commit intoNixOS:masterfrom
obsidiansystems:bintools-release-note

Conversation

@Ericson2314
Copy link
Member

Motivation for this change

#29396 needs an announcement.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ericson2314 Ericson2314 added the 8.has: documentation This PR adds or changes documentation label Dec 30, 2017
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO to me to create this, or just remove the warning

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Motivation: For another different one, I want to hyperlink a nixpkgs manual section, which is only readily done from within the nixpkgs manual.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we've intentionally restricted nixpkgs/NixOS release notes to NixOS as there is hardly any code which could not be added to both and we don't technically have releases for nixpkgs,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same argument would seem to work for merging the two manuals :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd agree, simply by looking at my behaviour of grepping through both every time I look for something. But that discussion should not start here, but rather on the mailing list or an RFC. :)

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 30, 2017
@Ericson2314 Ericson2314 requested a review from vcunat December 30, 2017 02:38
@Ericson2314 Ericson2314 mentioned this pull request Dec 30, 2017
13 tasks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we've intentionally restricted nixpkgs/NixOS release notes to NixOS as there is hardly any code which could not be added to both and we don't technically have releases for nixpkgs,

@Ericson2314 Ericson2314 force-pushed the bintools-release-note branch from 5b9dc1f to d67e092 Compare December 31, 2017 00:28
@Ericson2314 Ericson2314 merged commit fa9f0e5 into NixOS:master Dec 31, 2017
@Ericson2314 Ericson2314 deleted the bintools-release-note branch December 31, 2017 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants