Skip to content

Comments

wl-screenrec: 0.1.3 -> 0.1.4-unstable-2024-07-28#331628

Merged
colemickens merged 1 commit intoNixOS:masterfrom
emilazy:push-plukoopowzmx
Aug 2, 2024
Merged

wl-screenrec: 0.1.3 -> 0.1.4-unstable-2024-07-28#331628
colemickens merged 1 commit intoNixOS:masterfrom
emilazy:push-plukoopowzmx

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Aug 1, 2024

Description of changes

Includes support for FFmpeg 7. We can’t use the release tag because of a Cargo build issue; see russelltg/wl-screenrec#77. Hopefully there’ll be a new release tag soon.

Diff: russelltg/wl-screenrec@v0.1.3...b817acc

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from colemickens August 2, 2024 00:29
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 2, 2024
@colemickens
Copy link
Member

colemickens commented Aug 2, 2024

For some reason, when I applied this and tried to build:

╰🡒  nix build .#wl-screenrec
warning: Git tree '/home/cole/code/nixpkgs' is dirty
error: hash mismatch in fixed-output derivation '/nix/store/m27m32kwvdldbj7zb201wknz8r2kigj8-wl-screenrec-0.1.4-unstable-2024-07-28-vendor.tar.gz.drv':
         specified: sha256-dspknmYRb3BakKxGuJe05q1mSFRjTUfCXxSQJTDYtJQ=
            got:    sha256-AYirjrnk8SGTXk5IjzCep2AQJYPbgHAOOf47MUDYj4k=
error: 1 dependencies of derivation '/nix/store/4sg27hl2mb6j9p279wvd3s5d6g17hxnc-wl-screenrec-0.1.4-unstable-2024-07-28.drv' failed to build

Includes support for FFmpeg 7. We can’t use
the release tag because of a Cargo build issue; see
<russelltg/wl-screenrec#77>. Hopefully
there’ll be a new release tag soon.

Diff: <russelltg/wl-screenrec@v0.1.3...b817acc>
@emilazy emilazy force-pushed the push-plukoopowzmx branch from 4a1eb53 to d9b57ba Compare August 2, 2024 17:42
@emilazy
Copy link
Member Author

emilazy commented Aug 2, 2024

Uh, oops. I suspect I forgot to update the Cargo hash at some point when juggling versions, because I get the same hash if I clear it out. Try now?

Copy link
Member

@colemickens colemickens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test it locally, but it builds and runs on my server enough to print help text.

@colemickens
Copy link
Member

Okay, pulled it back locally and gave it a quick test. Seems to work better than I remember, nice!

Will merge.

@colemickens
Copy link
Member

@ofborg eval

@colemickens
Copy link
Member

okay clearly idk what I'm doing, I feel like I should wait for ofborg to eval and kick builds, but idk why it's not going.

@emilazy
Copy link
Member Author

emilazy commented Aug 2, 2024

It’s just really slow these days. No rush, though – I didn’t actually test this out locally either, I’m just here to remove ffmpeg_4 dependencies :)

@ofborg ofborg bot requested a review from colemickens August 2, 2024 18:42
@colemickens
Copy link
Member

lol ofborg, I already approved! Looks like it's just waiting on darwin, I'm going to merge it.

@colemickens colemickens merged commit 20b3191 into NixOS:master Aug 2, 2024
@emilazy
Copy link
Member Author

emilazy commented Aug 2, 2024

Thanks!

@emilazy emilazy mentioned this pull request Aug 21, 2024
13 tasks
@emilazy emilazy deleted the push-plukoopowzmx branch August 26, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants