Skip to content

ccextractor: 0.93 -> 0.94-unstable-2024-08-12#331615

Merged
emilazy merged 5 commits intoNixOS:masterfrom
emilazy:push-konptvsyvlnm
Aug 19, 2024
Merged

ccextractor: 0.93 -> 0.94-unstable-2024-08-12#331615
emilazy merged 5 commits intoNixOS:masterfrom
emilazy:push-konptvsyvlnm

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Aug 1, 2024

Description of changes

Linker script? What do you mean, linker script? Why would a simple leaf package like this have anything to do with linker scripts? No, stop, don’t look over there. Just don’t, okay? Trust me on this one.

I told you not to look…

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

emilazy added 4 commits August 1, 2024 20:57
I did once try to use this program (although it didn’t work, if I
recall correctly), so I guess I have no excuse not to…

If someone else stepped up to maintain this that would be better,
though.
@emilazy emilazy mentioned this pull request Aug 1, 2024
13 tasks
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 1, 2024
@emilazy emilazy force-pushed the push-konptvsyvlnm branch from 05ce3f9 to f85cb51 Compare August 2, 2024 16:17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the explicit link, we can way easier click on that

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the changelog depends on the version, there’s no way to make this a direct link. To quote the Nixpkgs manual:

A link or a list of links to the location of Changelog for a package. A link may use expansion to refer to the correct changelog version. Example: "https://git.savannah.gnu.org/cgit/hello.git/plain/NEWS?h=v${version}"

Copy link
Contributor

@Mindavi Mindavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks fine

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 10, 2024
@emilazy emilazy marked this pull request as draft August 11, 2024 23:43
@emilazy
Copy link
Member Author

emilazy commented Aug 11, 2024

They added tests; drafting for now until I check that those work.

@emilazy emilazy force-pushed the push-konptvsyvlnm branch from f85cb51 to abc8285 Compare August 12, 2024 18:41
@emilazy emilazy changed the title ccextractor: 0.93 -> 0.94-unstable-2024-07-17 ccextractor: 0.93 -> 0.94-unstable-2024-08-12 Aug 12, 2024
@emilazy emilazy marked this pull request as ready for review August 12, 2024 18:41
@emilazy
Copy link
Member Author

emilazy commented Aug 12, 2024

Upstream merged my build system PR, and there are tests now, and we can run them. Yay.

@emilazy
Copy link
Member Author

emilazy commented Aug 12, 2024

Result of nixpkgs-review pr 331615 run on aarch64-linux 1

1 package built:
  • ccextractor

Result of nixpkgs-review pr 331615 run on x86_64-linux 1

1 package built:
  • ccextractor

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 14, 2024
Includes fixes for Tesseract 5 and FFmpeg 7.
@emilazy emilazy force-pushed the push-konptvsyvlnm branch from abc8285 to 9562b3d Compare August 18, 2024 23:23
@emilazy emilazy merged commit 54df89b into NixOS:master Aug 19, 2024
@emilazy emilazy mentioned this pull request Aug 21, 2024
13 tasks
@emilazy emilazy deleted the push-konptvsyvlnm branch August 26, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments