earlyoom: use upstream systemd service and add proper test #331580
Conversation
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
11.by: package-maintainer
Building the manpage requires extra programs, namely Further, it is desirable to split outputs. A more restricted host environment can be stripped of some otherwise undesirable files to save space. |
github-actions
bot
added
8.has: documentation
| runHook postInstall | ||
| ''; | ||
| "PREFIX=${placeholder "out"}" | ||
| ] ++ lib.optional withManpage "MANDIR=${placeholder "man"}/share/man"; |
There was a problem hiding this comment.
Does this placeholder work? Usually I bumped into some issues.
There was a problem hiding this comment.
Does this placeholder work? Usually I bumped into some issues.
I'm not sure what issue are you referring to? With these options, the output layout looks correct for me.
wegank
added
the
12.approvals: 1
oxalica
force-pushed
the
pkg/earlyoom
branch
from
a34a342 to
acc2ec2
Compare
wegank
removed
the
12.approvals: 1
Stopped working after changes from NixOS/nixpkgs#331580
| default = [ ]; | ||
| example = [ | ||
| "-g" | ||
| "--prefer '(^|/)(java|chromium)$'" |
There was a problem hiding this comment.
This format seems to no longer work due to the call to lib.escapeShellArgs that wasn't previously there. I had to split out space-separated flags into individual list items: msfjarvis/dotfiles@a711550
Without the change in my configuration, the flag that ended up in EARLYOOM_ARGS was '--avoid '\\''^(gnome.*|firefox.*|pipewire.*|git.*)$'\\''' which was seen by earlyoom as a single parameter not a flag and caused the service to stop running.
There was a problem hiding this comment.
@msfjarvis Thanks, finally was looking into why my earlyoom service hasn't worked for a few days and saw this PR.
There was a problem hiding this comment.
@oxalica this needs a release note and the example fixed
Description of changes
It seems that we havewithManpageoption even though manual is installed to a separate outputman. If user only getoutin their closure when documentation is disabled, why would we need a separatewithManpageflag? Could we remove and always enable it?Ok, I kept it with a comment. It may be useful when someone is targeting a platform without pandoc.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.