treewide: finalAttrs.doCheck -> finalAttrs.finalPackage.doCheck#331116
Merged
pbsds merged 1 commit intoNixOS:masterfrom Aug 1, 2024
Merged
treewide: finalAttrs.doCheck -> finalAttrs.finalPackage.doCheck#331116pbsds merged 1 commit intoNixOS:masterfrom
pbsds merged 1 commit intoNixOS:masterfrom
Conversation
repeat of NixOS#271241 discussion: NixOS#272978 I did not replace the instance in eiwd, since it causes an infinite recursion.
Contributor
|
If you'd like a ✅ and someone to look these over, I'll always give you one on PRs like this @pbsds. 💚 |
Member
Author
|
is that offer for treewides in general, or simple find-replaces? edit: i just saw #335232, i assume the former :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
repeat of #271241
discussion: #272978
I did not replace the other instance in eiwd, since it causes an infinite recursion.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.