Skip to content

treewide: finalAttrs.doCheck -> finalAttrs.finalPackage.doCheck#331116

Merged
pbsds merged 1 commit intoNixOS:masterfrom
pbsds:fix-finalattrs-docheck-1722356587
Aug 1, 2024
Merged

treewide: finalAttrs.doCheck -> finalAttrs.finalPackage.doCheck#331116
pbsds merged 1 commit intoNixOS:masterfrom
pbsds:fix-finalattrs-docheck-1722356587

Conversation

@pbsds
Copy link
Member

@pbsds pbsds commented Jul 30, 2024

Description of changes

repeat of #271241
discussion: #272978

I did not replace the other instance in eiwd, since it causes an infinite recursion.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

repeat of NixOS#271241
discussion: NixOS#272978

I did not replace the instance in eiwd, since it causes an infinite recursion.
@pbsds pbsds marked this pull request as ready for review July 30, 2024 16:59
@pbsds pbsds requested a review from RaitoBezarius as a code owner July 30, 2024 16:59
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 30, 2024
@pbsds pbsds merged commit b926e6e into NixOS:master Aug 1, 2024
@philiptaron
Copy link
Contributor

If you'd like a ✅ and someone to look these over, I'll always give you one on PRs like this @pbsds. 💚

@pbsds
Copy link
Member Author

pbsds commented Aug 20, 2024

is that offer for treewides in general, or simple find-replaces?

edit: i just saw #335232, i assume the former :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants