Merged
Conversation
ofborg
bot
added
10.rebuild-darwin: 1-10
emilazy
approved these changes
Jul 29, 2024
Member
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
Result of nixpkgs-review pr 330842 run on x86_64-linux 1
15 packages built:
- ffmpeg_7-full
- ffmpeg_7-full.bin
- ffmpeg_7-full.data
- ffmpeg_7-full.dev
- ffmpeg_7-full.doc
- ffmpeg_7-full.lib
- ffmpeg_7-full.man
- handbrake
- nixpkgs-manual
- xevd
- xevd.dev
- xevd.lib
- xeve
- xeve.dev
- xeve.lib
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Add upstream patches that include linking libm into the shared library, mpeg5/xevd#70 and mpeg5/xeve#132. This allows us to drop passing
-lmin CFLAGS, which should probably actually be in LDFLAGS.These patches are mostly a nice-to-have for the Darwin PR but taking them now means the next version bump will just be removing the patches rather than remembering the
-lmflag can be dropped.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.