Skip to content

Comments

haskellPackages.tasty_1_5_1: fix#330643

Merged
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
hercules-ci:fix-haskellPackages.tasty_1_5_1
Jul 28, 2024
Merged

haskellPackages.tasty_1_5_1: fix#330643
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
hercules-ci:fix-haskellPackages.tasty_1_5_1

Conversation

@roberth
Copy link
Member

@roberth roberth commented Jul 28, 2024

Description of changes

Fix a trivial bug to unblock tasty 1.5.1.

Tasty 1.5.1 was faux-revoked because of this. For context:

I've tried to downgrade tasty using the tooling, but didn't manage to without also updating other hackage package versions, so I figured this is the easy route.
Turns out it was just a little output formatting bug.

I have to agree with peti that this was a waste of time, but here we are. It's a fix.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Jul 28, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jul 28, 2024
@maralorn maralorn merged commit 2abfffa into NixOS:haskell-updates Jul 28, 2024
@maralorn
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants