Skip to content

nixos/speechd: avoid by default on headless systems#330440

Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom
vcunat:p/speechd-default
Jul 28, 2024
Merged

nixos/speechd: avoid by default on headless systems#330440
vcunat merged 1 commit intoNixOS:staging-nextfrom
vcunat:p/speechd-default

Conversation

@vcunat
Copy link
Member

@vcunat vcunat commented Jul 27, 2024

Incidentally this also fixes tests like nixosTests.installer.simple /cc PR #329658

Things done

  • Built on platform(s): N/A
  • Tested, as applicable:
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jul 27, 2024
@vcunat
Copy link
Member Author

vcunat commented Jul 27, 2024

Feel free to suggest a better magic to guess the default, now or later.

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 27, 2024
Comment on lines 20 to 23
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we move this into graphical-desktop.nix instead of doing guess work here?

Also just noticed the same 😂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do that. I'm not sure which approach is better.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the generic graphic module and it's purpose is to collect all those things, that you only want to turn on on graphical systems, like this setting.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, moved there and retested.

@SuperSandro2000 SuperSandro2000 requested a review from K900 July 27, 2024 17:27
Incidentally this also fixes tests like nixosTests.installer.simple
/cc PR NixOS#329658
@vcunat vcunat force-pushed the p/speechd-default branch from d6e2df7 to 1e9b3c1 Compare July 28, 2024 10:16
@vcunat vcunat merged commit ca0d8e5 into NixOS:staging-next Jul 28, 2024
@vcunat
Copy link
Member Author

vcunat commented Jul 28, 2024

Let's remove this blocker. Feel free to improve/change later.

@vcunat vcunat deleted the p/speechd-default branch July 28, 2024 11:01
@SuperSandro2000
Copy link
Member

The merged version LGTM

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/how-to-remove-speech-dispatcher/49957/2

@solna86
Copy link

solna86 commented Sep 23, 2024

Is there a reason why services.speechd.enable defaults to true in graphical desktops (at least on unstable)?

NixOS is quite minimal by default, with very few processes running. Setting this option to true results in 4 or 5 new daemons getting spawn when one opens e.g. a web browser.

@K900
Copy link
Contributor

K900 commented Sep 23, 2024

Because if a person needs a screen reader to use their computer, they can't use their computer to install a screen reader.

@solna86
Copy link

solna86 commented Sep 23, 2024

OK, fair enough. But I would typically imagine they'd enable this during installation using the live image.

@K900
Copy link
Contributor

K900 commented Sep 23, 2024

There is currently no such option in the installer. If one was to be added, we could revisit this.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Sep 24, 2024

I have collected the necessary options to disable speechd completely and get a smaller installation here https://github.com/NuschtOS/nixos-modules/blob/main/modules/slim.nix

@solna86
Copy link

solna86 commented Sep 24, 2024

I have collected the necessary options to disable speechd completely and get a smaller installation here https://github.com/NuschtOS/nixos-modules/blob/main/modules/slim.nix

That's actually a good idea. Right now, NixOS is still quite minimal. There's not that much apart from speechd on by default on a graphical desktop as specified in graphical-desktop.nix?

But, perhaps, if options for the graphical system grow too much, it might be worth considering to offer a slimmer alternative set of defaults, especially for those that only have a WM enabled but no desktop environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants